Bug fixes w/ current Github API - #4
Open
UriShX wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried using the extension and kept getting failure responses, so I changed a couple of things for it to work with the current Github API.
Changed repository list fetching URL since it retrieves only public repos. Changed from
/orgs/${user}/repostosearch/repositories?q=user:${user}according to this thread and Github's API documentation.Removed
committerfromputContent()since according to the repository API documentation it defaults to correct values.I got to this since my own email is hidden, which caused the extension to fail.
I also bumped the version.
Hope you approve this and re-publish the extension, it looks like a good productivity tool.
Cheers,
Uri