refactor(errors): extract network hint dispatch and formatting

[luojiyin1987]

What

Extract network error hint dispatch and hint-line formatting out of src/index.ts.

getNetworkErrorHint() now lives in src/utils/network.ts, and formatHintLines() now lives in src/output/formatters.ts.

Why

• Eliminates 5 identical if/else branches that each repeat the same chalk formatting
• Provides reusable error handling utilities for the upcoming dispatch layer (PR 5)
• Keeps network hint dispatch in utils/network.ts
• Keeps chalk-based formatting in output/formatters.ts

Changes

• src/utils/network.ts: add getNetworkErrorHint() for network hint dispatch
• src/output/formatters.ts: add formatHintLines() for shared hint formatting
• src/index.ts: replace repeated network hint if/else block with composed helper calls
• Tests: cover all getNetworkErrorHint() branches and formatHintLines() formatting behavior

Testing

• TypeScript compiles cleanly
• No behavior change (same hints, same formatting, same fallback to fetchErrorCaCertHint)

Closes #823

[sonukapoor]

Thanks for picking this up - the 20-line if/else block is genuine duplication and extracting it is the right call. The routing logic is clean and the behavioral output is preserved exactly.

My main concern is the module placement. formatHintLines is a chalk formatting utility - it does the same work as formatRelationshipLabel and formatAdvisorySourceLine in formatters.ts, so that's where it belongs. And getNetworkErrorHint has no chalk dependency at all - it only calls functions that already live in network.ts, so it fits there naturally. Those two moves achieve the full index.ts cleanup you're after without needing a new cli-errors.ts file.

The other gap is tests. Every detection function in network.ts is covered in tests/network.test.ts - the two new functions should get the same treatment. formatHintLines has an empty-input branch, getNetworkErrorHint has five branches, both need coverage.

[luojiyin1987]

Thanks, that makes sense. I’ll drop the new cli-errors module and move the helpers into the existing boundaries: formatHintLines into output/formatters.ts, and getNetworkErrorHint into utils/network.ts.

I’ll also add coverage for the empty formatHintLines input case and all five getNetworkErrorHint branches.

[sonukapoor]

This is exactly what I was looking for - formatHintLines in formatters.ts alongside the other chalk formatting helpers, getNetworkErrorHint in network.ts where all the detection logic already lives, and no new file needed. The test coverage is thorough too: all five branches of getNetworkErrorHint in network.test.ts and both paths of formatHintLines in output.test.ts. Well done.