feat/cubit: add controls for microstructure meshing - #192
Open
gknapp1 wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Final stacked PR from the
feat/thesis/eol-tempsplit. This isolates the remaining Cubit-focused work: lower-memory orientation mapping, added meshing controls, and the associated example updates.Related issues
Details
This PR adds a serial orientation-mapping mode for
vtk_to_exodus_regioncontrolled by--orientation-segment-gb, allowing large cases to trade throughput for reduced peak memory during orientation transfer.It also adds additional meshing control arguments for Cubit/SPN meshing workflows and extends the behavior tests and parser coverage for those options.
The example updates that depend on those Cubit options are carried here so the final stacked branch preserves the original feature branch behavior while keeping the Deer container support isolated to PR 1.
Included commits:
5904ea1feat(cubit): serialize orientation mapping to reduce memory useb7b3e8bfeat(cubit): add meshing control argumentsImpact
This changes Cubit workflow behavior by adding new execution-time controls and a lower-memory path for orientation mapping. It should improve operability for larger meshes while preserving the existing workflow for users who do not opt into the new arguments.
Risk level: Medium. The changes are concentrated in one Cubit app, but they affect meshing and orientation-transfer behavior and therefore deserve careful review of the new execution paths.
Architecture/docs: no update needed - this extends an existing Cubit application with additional execution controls without changing subsystem boundaries.
Testing strategy
Commit hooks passed during commit creation.
Covered by focused tests in CI-relevant areas:
tests/test_cubit_vtk_to_exodus_region_behavior.pytests/test_app_argument_parsing.pyStack context:
stack/thesisstack/cubitChecklist
ARCHITECTURE.mdand/ordeveloper docs where needed, or explained why not.