fix: save button unavailable when checking Organization Owner#1523
Open
DanielPalafox wants to merge 1 commit into
Open
fix: save button unavailable when checking Organization Owner#1523DanielPalafox wants to merge 1 commit into
Organization Owner#1523DanielPalafox wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix 1: Save button unavailable when checking "Organization Owner"
Fixed a bug in the validateOrgOwners() method where the isSaving flag was not being reset in all cases. When users checked the "Organization Owner" checkbox, isSaving was set to true, but if the organization (memberId) wasn't yet selected, the flag was never reset to false, leaving the Save button permanently disabled.
Solution: Added the finalize RxJS operator to ensure isSaving is always reset when the subscription completes, regardless of success or failure. Also added an else branch to handle the case when memberId is not set.
https://orcid.clickup.com/t/9014437828/PD-5923