Repository navigation
libutee: validate TEE_ReadObjectData output buffer - #7983
Conversation
|
A corresponding regression test has been added in optee_test: OP-TEE/optee_test#833 |
|
Since this is a fix, please add a fixes tag, probably: With that: |
9a0b651 to
a1b98ce
Compare
|
Thanks! I've added the Fixes and Reviewed-by tags. |
|
I'll merge this when the CI tests have passed. |
a1b98ce to
fe10fc9
Compare
|
It appears there's a problem with secure_storage-rs, probably due to using shared memory, which this PR tightens up the checks for. @ivila can you check, please? |
Yes，will do |
Fixes by OP-TEE/manifest#356 |
|
Hopefully, CI tests should pass now. |
|
Rebase and force push the change. I think there's some cache issue that usually gets resolved by that. |
Check the data buffer against the [out] annotation before reading persistent-object data. This prevents client-shared memory from being used where the API requires a private TA output buffer. The count output was already validated; validate the data output as well. Fixes: 6915bbb ("GP 1.1: Check parameters annotated in the specification") Signed-off-by: Jaehun Lee <gsojc234@gmail.com> Reviewed-by: Jens Wiklander <jens.wiklander@oss.qualcomm.com>
fe10fc9 to
a5aa4e3
Compare
Check the data buffer against the [out] annotation before reading persistent-object data. This prevents client-shared memory from being used where the API requires a private TA output buffer.
The count output was already validated; validate the data output as well.