fix: persist sandbox before asynchronous bootstrap - #2
Merged
Conversation
(cherry picked from commit d0438e08e8c1eca695824a3e2a245cd16c5811b1)
(cherry picked from commit ebd0aa80f65ddbf780c1367b0f1aeb92c3f2fe8d)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The deployed sandbox create path can start lengthy desktop/Claude bootstrap work before a durable sandbox identity is returned. This prevents reliable cancellation and cleanup.
Change
provisioningsandbox identity before bootstrapVerification
pnpm --filter @onecli/api test -- src/routes/sandboxes.test.ts(2 passed)