Conversation
helman101
left a comment
helman101
left a comment
There was a problem hiding this comment.
STATUS: CHANGES REQUIRED ♻️ 🔴
Hi @OLIPLICHE 👋,
Nice job so far with this project 😄, but there are still some changes to do.
Required Changes ♻️
- Check the comments under the review.
Cheers and Happy coding!👏👏👏
If anything is not 100% clear please leave your questions or comments in the PR thread, we will be glad to help you 😄.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
| attr_reader :id | ||
|
|
||
| def initialize(age, name = 'Unknown', parent_permission: true) | ||
| @id = Random.ran(1..1000) |
There was a problem hiding this comment.
- You have a little mistake here the method that you are trying to use with
Randomis.rand(...)and not.ran(...), please change this 😄
mikethreels
left a comment
mikethreels
left a comment
There was a problem hiding this comment.
Hi Paka,
Your project is complete! There is nothing else to say other than... it's time to merge it 🚀 :
Congratulations! 🎉
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Associations
3 participants
School library