self controlled cohort module - #293
Open
azimov wants to merge 44 commits into
Open
Conversation
# Conflicts: # DESCRIPTION
* Updating evidence synthesis results schema fro balance diagnostic and target_comparator_id * Balance meta-analysis and switching to target_comnparator_id * Fixing balance meta-analysis * Formally importing pnorm from stats to avoid R check note --------- Co-authored-by: Admin_mschuemi <Admin_mschuemi@its.jnj.com>
… and place them within the package
# Conflicts: # DESCRIPTION
# Conflicts: # R/Module-EvidenceSynthesis.R # inst/csv/evidenceSynthesisRdms.csv # inst/testdata/cdmModulesAnalysisSpecifications.json # tests/testthat/test-EvidenceSynthesisModule.R
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #293 +/- ##
===========================================
- Coverage 97.15% 95.76% -1.40%
===========================================
Files 16 17 +1
Lines 4992 5383 +391
===========================================
+ Hits 4850 5155 +305
- Misses 142 228 +86 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
|
@azimov thanks for adding this module! This all looks good with the exception of the unit tests for EvidenceSynthesis. I noted that you have added another set of unit tests for the ES module and am wondering if we could incorporate the SCC results into the existing EvidenceSythesis approach that @schuemie has established in the package? I believe the path forward would look something like this:
Please let me know your thoughts on this approach. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds code to support SelfControlledCohort package (now in cran), with EvidenceSynthesis support