Skip to content

Release v1.5 - #290

Merged
anthonysena merged 12 commits into
mainfrom
develop
Mar 19, 2026
Merged

Release v1.5#290
anthonysena merged 12 commits into
mainfrom
develop

Conversation

@anthonysena

Copy link
Copy Markdown
Collaborator

No description provided.

ncittm and others added 12 commits September 25, 2025 13:11
* fixed data types and added cdm_version_concept_id

* missed col value

* target_id as int

* changed yes/no
* multiple analysis

* add table to data model

* fix to data model

* fixed test cases

* better error handling

Update TreatmentPatternsModule.Rd

* Issue 255 treatment patterns data model (#272)

* fixed data types and added cdm_version_concept_id

* missed col value

* target_id as int

* changed yes/no

* Duplicate table

Removed duplicate table in treatmentPatternsRdms.csv

* conflict documentation fix

* added new test cases

* updated data model

* Update treatmentPatternsRdms.csv

* fixed createModuleSpecifications

* snakeCase Issue and cohorts tbl logic

* Update treatmentPatternsRdms.csv

* Update treatmentPatternsRdms.csv

* prefix tbl bug

---------

Co-authored-by: Admin_SInduku2 <Admin_SInduku2@its.jnj.com>
* Always create the full results data model

* Fix documentation

* Fix test
* Initial code for saving and loading template definitions

* testing changes for saving definitions

* debug removed

* using lists correctly

* Don't store hash names, seems to create an issue

* Modified storage of values in list to test odd behaviour

* fixed whitespace changes

* CG branch updated to develop line

* CG 1.0.0

* incrementalFolder parameter removed
* Initial draft of updates to support CM v6

* Issue 275 balance meta analysis (#278)

* Updating evidence synthesis results schema fro balance diagnostic and target_comparator_id

* Balance meta-analysis and switching to target_comnparator_id

* Fixing balance meta-analysis

* Formally importing pnorm from stats to avoid R check note

---------

Co-authored-by: Admin_mschuemi <Admin_mschuemi@its.jnj.com>

* Add logging to results data model creation and upload

* Adding tryCatch around metafor::rma. Including changes from PR 282

* Fix balance synthesis when no analysis is unblinded

* Implementing prediction intervals in evidence synthesis (#284)

* Fixed error when calibrating prediction intervals when there is no data

* Minor fix to prediction interval calibration

* Adding missing join variable to ES

* Setting required EvidenceSynthesis version to 1.1.0

* Handling some more edge cases in ES

* Updating ES unit test

---------

Co-authored-by: Martijn Schuemie <schuemie@ohdsi.org>
Co-authored-by: Admin_mschuemi <Admin_mschuemi@its.jnj.com>
… package contributors (#287)

* Disable TP unit tests per #286

* Add full list of contributors
* updating strategus module for characterization v3.0

- added new settings (targetBaseline, riskFactor, caseSeries)
- added new filters (minSMD, minCovariateCount)
- added mode input
- added new output table name
- updated Description to specify char >= 3.0

* Update branch references in DESCRIPTION

* Temporarily require lower version of Char for testing

* Update cdmModulesAnalysisSpecifications.json

updating char test spec

* Update cdmModulesAnalysisSpecifications.json

* Update cdmModulesAnalysisSpecifications.json

- changing char example TAR to get results for risk factor and case series

* Require Char v3, update script to generate testdata

---------

Co-authored-by: jreps <jreps@its.jnj.com>
* Run styler

* Update copyright year

* Update NEWS and documentation

* Regenerate manuals

* Run pkgdown::check

* Update results data model
@anthonysena
anthonysena merged commit d53ff4d into main Mar 19, 2026
7 checks passed
@codecov

codecov Bot commented Mar 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.04797% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.09%. Comparing base (8a002fa) to head (3c05551).
⚠️ Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
R/Module-EvidenceSynthesis.R 95.75% 16 Missing ⚠️
R/Module-Characterization.R 96.19% 4 Missing ⚠️
R/Module-CohortMethod.R 97.67% 1 Missing ⚠️
R/Module-TreatmentPatterns.R 99.53% 1 Missing ⚠️
R/ResultDataModel.R 96.29% 1 Missing ⚠️
R/StrategusModule.R 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #290      +/-   ##
==========================================
- Coverage   97.82%   97.09%   -0.74%     
==========================================
  Files          16       16              
  Lines        4193     5683    +1490     
==========================================
+ Hits         4102     5518    +1416     
- Misses         91      165      +74     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants