Skip to content

Bump the trexsql base image to trex #305 - #3321

Open
p-hoffmann wants to merge 1 commit into
developfrom
p-hoffmann/bump-trexsql-base
Open

Bump the trexsql base image to trex #305#3321
p-hoffmann wants to merge 1 commit into
developfrom
p-hoffmann/bump-trexsql-base

Conversation

@p-hoffmann

Copy link
Copy Markdown
Member

No description provided.

Moves the pinned base from trex #261 to #305, both variants kept in step:
prod-sha for the lean base in Dockerfile.v2, plain sha for the full base used
by the local compose file and the CI build.

This is the newest published trexsql image. #306 and #308 are merged on trex
develop but have no image: their develop-push runs fail core-server-tests
(two buildSdkTools cases) and the studio build (submodule init, then npm
edgesOut), and the docker publish jobs are gated on that aggregate. So the
cache-build and job-tracking fixes from #308 are NOT in this bump; it needs a
second one once trex publishing is healthy again.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is a straightforward, consistent update of pinned base-image references across prod and devx build paths.

Pull request overview

Updates the trexsql base image references used to build d2e-trex so the service images are built on the newer upstream trexsql (trex #305), while keeping both the lean “prod” base and the “full/devx” base pinned by tag+digest.

Changes:

  • Bumped services/trex/Dockerfile.v2 default TREXSQL_REF to the new prod-sha-...@sha256:... reference (lean/prod base).
  • Bumped the TREXSQL_REF build-arg default in docker-compose-local.yml to the new sha-...@sha256:... reference (full/devx base).
  • Bumped the CI devx build TREXSQL_REF in .github/workflows/docker-build-push.yaml to match the local devx reference.
File summaries
File Description
services/trex/Dockerfile.v2 Updates the default pinned trexsql prod base reference used for standard d2e-trex builds.
docker-compose-local.yml Updates the pinned trexsql full/devx base reference used for local -devx builds.
.github/workflows/docker-build-push.yaml Updates the pinned trexsql full/devx base reference used for CI -devx builds.
Review details
  • Files reviewed: 3/3 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants