fix(cohorts): keep wizard dropdowns inside the modal - #3311
Open
jerome-ng wants to merge 2 commits into
Open
Conversation
jerome-ng
requested review from
LSriragavan,
brandantck,
khairul-syazwan,
maggie-li-yd and
p-hoffmann
as code owners
September 8, 2026 23:01
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The boundary ignores the outer scrolling modal body, allowing overflow on shorter viewports.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Constrains the required-filter typeahead dropdown within the modal’s visible area.
Changes:
- Hides dropdowns when inputs are clipped.
- Sizes and flips dropdowns against the form boundary.
File summaries
| File | Description |
|---|---|
ConceptSetTypeaheadField.vue |
Updates teleported dropdown positioning and visibility. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+212
to
+216
| const boundary = input.closest('.required-filters-modal')?.getBoundingClientRect() | ||
| const top = Math.max(0, boundary?.top ?? 0) | ||
| const bottom = Math.min(window.innerHeight, boundary?.bottom ?? window.innerHeight) | ||
| const left = Math.max(0, boundary?.left ?? 0) | ||
| const right = Math.min(window.innerWidth, boundary?.right ?? window.innerWidth) |
khairul-syazwan
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix wizard dropdowns overflowing the Cohort Builder modal during scrolling. Position menus within the modal’s bounding box, hide them when their input scrolls out of view, and refresh their position when reopened by keyboard.