[18.0][FIX] password_security: update password_write_date on copy#964
Open
moylop260 wants to merge 1 commit into
Open
[18.0][FIX] password_security: update password_write_date on copy#964moylop260 wants to merge 1 commit into
moylop260 wants to merge 1 commit into
Conversation
Sometimes users are created from a template user via copy(). This means a password can be passed in the copy values and never seen by write(), so password_write_date may remain inherited from the template user. This forward-port keeps the original fix: - set password_write_date with copy=False - validate signup password against the correct user when 2FA is enabled - add regression coverage for cloned users Forward-port of OCA#713 Original commit: f8c4092 (cherry picked from commit f8c4092)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward-port of #713 to 18.0.
Original commit: f8c4092
This keeps the original minimal fix:
cc @moylop260