Skip to content

[19.0][MIG] project_task_ancestor: Migration to 19.0#1731

Merged
OCA-git-bot merged 3 commits into
OCA:19.0from
moduon:19.0-mig-project_task_ancestor
May 26, 2026
Merged

[19.0][MIG] project_task_ancestor: Migration to 19.0#1731
OCA-git-bot merged 3 commits into
OCA:19.0from
moduon:19.0-mig-project_task_ancestor

Conversation

@chienandalu
Copy link
Copy Markdown
Member

@chienandalu chienandalu commented May 19, 2026 •
edited
Loading

image

cc @moduon MT-14695

please review @Gelojr @Shide

@OCA-git-bot OCA-git-bot added series:19.0 mod:project_task_ancestor Module project_task_ancestor labels May 19, 2026
RuxMgit
RuxMgit approved these changes May 21, 2026
View reviewed changes
Copy link
Copy Markdown

@RuxMgit RuxMgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM 👍

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented May 24, 2026

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@rafaelbn
Copy link
Copy Markdown
Member

rafaelbn commented May 25, 2026

/ocabot migration project_task_ancestor

@OCA-git-bot OCA-git-bot added this to the 19.0 milestone May 25, 2026
@OCA-git-bot OCA-git-bot mentioned this pull request May 25, 2026
Open
44 tasks
rafaelbn
rafaelbn approved these changes May 25, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 Thank you!

/ocabot merge patch

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented May 25, 2026

This PR looks fantastic, let's merge it!
Prepared branch 19.0-ocabot-merge-pr-1731-by-rafaelbn-bump-patch, awaiting test results.

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented May 25, 2026

@rafaelbn your merge command was aborted due to failed check(s), which you can inspect on this commit of 19.0-ocabot-merge-pr-1731-by-rafaelbn-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@rafaelbn
Copy link
Copy Markdown
Member

rafaelbn commented May 25, 2026

Hello @chienandalu , please review

@rafaelbn your merge command was aborted due to failed check(s), which you can inspect on this commit of 19.0-ocabot-merge-pr-1731-by-rafaelbn-bump-patch.

@chienandalu chienandalu force-pushed the 19.0-mig-project_task_ancestor branch from 8b836e3 to eab440b Compare May 25, 2026 12:35
@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented May 25, 2026

What a great day to merge this nice PR. Let's do it!
Prepared branch 19.0-ocabot-merge-pr-1731-by-rafaelbn-bump-patch, awaiting test results.

@chienandalu
Copy link
Copy Markdown
Member Author

chienandalu commented May 25, 2026

I'm pushing a rebase. Let's see how it goes

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented May 25, 2026

@rafaelbn your merge command was aborted due to failed check(s), which you can inspect on this commit of 19.0-ocabot-merge-pr-1731-by-rafaelbn-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@chienandalu
Copy link
Copy Markdown
Member Author

chienandalu commented May 25, 2026

@rafaelbn merge here first: #1733

@BhaveshHeliconia
Copy link
Copy Markdown
Contributor

BhaveshHeliconia commented May 26, 2026

@rafaelbn merge here first: #1733

@chienandalu it has been merged. Could you please rebase?

BhaveshHeliconia
BhaveshHeliconia approved these changes May 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@BhaveshHeliconia BhaveshHeliconia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functional review LGTM!

@rafaelbn
Copy link
Copy Markdown
Member

rafaelbn commented May 26, 2026

/ocabot rebase

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented May 26, 2026

@rafaelbn The rebase process failed, because command git push --force moduon tmp-pr-1731:19.0-mig-project_task_ancestor failed with output:

remote: Permission to moduon/project.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/moduon/project/': The requested URL returned error: 403

@rafaelbn
Copy link
Copy Markdown
Member

rafaelbn commented May 26, 2026

Hello @chienandalu , please could you rebase here?

Andrii Kompaniiets and others added 2 commits May 26, 2026 10:40
@chienandalu
[ADD] project_task_ancestor: New module
85b05e1 
This module restores the ancestor task field with its associated logic,
making it available again in Timesheets and Project reports.

MT-12302
@mymage @chienandalu
Added translation using Weblate (Italian)
5497ac2
@chienandalu chienandalu force-pushed the 19.0-mig-project_task_ancestor branch from eab440b to 1b95963 Compare May 26, 2026 08:40
@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented May 26, 2026

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 19.0-ocabot-merge-pr-1731-by-rafaelbn-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 899c745 into OCA:19.0 May 26, 2026
7 checks passed
@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented May 26, 2026

Congratulations, your PR was merged at 482bc81. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rafaelbn rafaelbn rafaelbn approved these changes

+3 more reviewers

@Shide Shide Shide approved these changes

@RuxMgit RuxMgit RuxMgit approved these changes

@BhaveshHeliconia BhaveshHeliconia BhaveshHeliconia approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 mod:project_task_ancestor Module project_task_ancestor ready to merge series:19.0

Projects

None yet

Milestone

19.0

Development

Successfully merging this pull request may close these issues.

7 participants

@chienandalu @OCA-git-bot @rafaelbn @BhaveshHeliconia @Shide @RuxMgit @mymage