[18.0][FIX] pos_config_logo: embed POS logo on the receipt - #1607
Open
MiguelMachadoM wants to merge 1 commit into
Open
[18.0][FIX] pos_config_logo: embed POS logo on the receipt#1607MiguelMachadoM wants to merge 1 commit into
MiguelMachadoM wants to merge 1 commit into
Conversation
MiguelMachadoM
force-pushed
the
18.0-fix-pos-config-logo-receipt-embed
branch
3 times, most recently
from
August 31, 2026 13:27
f38ef25 to
0b73638
Compare
The 18.0 migration used an absolute web.base.url image URL that returns the camera placeholder without a session. Embed the binary already loaded on the POS, as 16.0 did with a data URI. Co-authored-by: Cursor <cursoragent@cursor.com>
MiguelMachadoM
force-pushed
the
18.0-fix-pos-config-logo-receipt-embed
branch
from
August 31, 2026 14:00
0b73638 to
fb879df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 18.0 migration used
${session._base_url}/web/image?model=pos.config. That URL needs a session;pos.config.logois not public. If the host does not matchweb.base.url(or print has no cookie), Odoo returns the camera placeholder.This restores a data URI from the binary already loaded on the POS (16.0 behaviour), with a relative
/web/imagefallback.Independent of #1546. Runboat often does not reproduce this (same host as
web.base.url). See odoo/odoo#228173.