Skip to content

[19.0][MIG] pos_order_remove_line: Migration to 19.0 - #1604

Open
robperezit wants to merge 3 commits into
OCA:19.0from
robperezit:19.0-mig-pos_order_remove_line-v2
Open

[19.0][MIG] pos_order_remove_line: Migration to 19.0#1604
robperezit wants to merge 3 commits into
OCA:19.0from
robperezit:19.0-mig-pos_order_remove_line-v2

Conversation

@robperezit

Copy link
Copy Markdown

Migration of pos_order_remove_line to Odoo 19.0.

Summary of changes:

  • Preserved full Git history and original authorship.
  • Refactored JS to use native Odoo 19 props.mode === 'display' for button visibility.
  • Simplified XML/SCSS templates to match the new POS UI.
  • Updated line removal logic to use remove_orderline.

@OCA-git-bot OCA-git-bot added series:19.0 mod:pos_order_remove_line Module pos_order_remove_line labels Aug 24, 2026
@kalpeshgajera-uncannycs

Copy link
Copy Markdown

@robperezit Could you please squash the two commits into one, as they are part of the same migration work? This will keep the PR history clean and aligned with OCA guidelines.

Reference:
https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests

@robperezit
robperezit force-pushed the 19.0-mig-pos_order_remove_line-v2 branch from d9b5f5d to 8c5292f Compare August 31, 2026 22:36
@robperezit

Copy link
Copy Markdown
Author

Hi @kalpeshgajera-uncannycs
Thanks for the review. I have squashed the migration commits into a single commit as requested. It's ready for review now.

Comment thread pos_order_remove_line/static/src/js/orderline.esm.js Outdated
[FIX] Apply pre-commit auto-fixes for pos_order_remove_line

[FIX] use camelCase removeOrderline
@robperezit
robperezit force-pushed the 19.0-mig-pos_order_remove_line-v2 branch from 8c5292f to 2a44828 Compare September 1, 2026 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mod:pos_order_remove_line Module pos_order_remove_line series:19.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants