[IMP] pms: charge non per-day services on current date for on board reservations#418
Merged
OCA-git-bot merged 1 commit intoJun 26, 2026
Conversation
…eservations A non per-day service added to a reservation was always dated on the reservation checkout date. When the service is added while the guest is already on board (e.g. a drink or a parking charged at the front desk), this placed the charge on the last day of the stay instead of the day it is actually consumed. Charge non per-day services on the current date, in the property timezone, whenever the reservation is already on board. Per-day services and services consumed on check-in keep their previous behavior.
Member
Author
|
/ocabot merge minor |
Contributor
|
Hey, thanks for contributing! Proceeding to merge this for you. |
Contributor
|
Congratulations, your PR was merged at 15785aa. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A non per-day service added to a reservation is always dated on the reservation checkout date. When the service is added while the guest is already on board (e.g. a drink, a parking spot or any extra charged at the front desk during the stay), this places the charge on the last day of the stay instead of the day it is actually consumed.
Change
In
pms.service._compute_service_line_ids, when a non per-day product is added to a reservation whose state isonboard, the auto-created service line is now dated on the current date (property timezone) instead of the checkout date.Behavior left unchanged:
per_day = True) still create one line per night.consumed_on = "checkin") still use the check-in date.