Skip to content

[19.0] [MIG] account_invoice_margin_sale superseed#258

Merged
OCA-git-bot merged 23 commits into
OCA:19.0from
Studio73:19.0-mig-account_invoice_margin_sale-superseed
Jun 26, 2026
Merged

[19.0] [MIG] account_invoice_margin_sale superseed#258
OCA-git-bot merged 23 commits into
OCA:19.0from
Studio73:19.0-mig-account_invoice_margin_sale-superseed

Conversation

@eugenios73

@eugenios73 eugenios73 commented Mar 2, 2026 •
edited
Loading

Copy link
Copy Markdown

superseeded #255

Depends on #270

oca-travis and others added 21 commits January 8, 2026 12:57
@oca-travis @Debora7
[UPD] Update account_invoice_margin_sale.pot
5865087
@HaraldPanten @Debora7
Added translation using Weblate (Spanish)
fde1611
@HaraldPanten @Debora7
Translated using Weblate (Spanish)
873aca6 
Currently translated at 100.0% (1 of 1 strings)

Translation: margin-analysis-13.0/margin-analysis-13.0-account_invoice_margin_sale
Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-13-0/margin-analysis-13-0-account_invoice_margin_sale/es/
@Debora7
[IMP] skip margin calculation for Down Payment invoice
52c98be 
[UPD] Update account_invoice_margin_sale.pot

[UPD] README.rst

account_invoice_margin_sale 13.0.1.0.1

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: margin-analysis-13.0/margin-analysis-13.0-account_invoice_margin_sale
Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-13-0/margin-analysis-13-0-account_invoice_margin_sale/
@Reyes4711-S73 @Debora7
[14.0][MIG] account_invoice_margin_sale: Migration to 14.0
7683e4a 
[UPD] Update account_invoice_margin_sale.pot

[UPD] README.rst
@rafamarpe @Debora7
Translated using Weblate (Spanish)
da14bb2 
Currently translated at 100.0% (3 of 3 strings)

Translation: margin-analysis-14.0/margin-analysis-14.0-account_invoice_margin_sale
Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-14-0/margin-analysis-14-0-account_invoice_margin_sale/es/
@victoralmau @Debora7
[MIG] account_invoice_margin_sale: Migration to 15.0
fc18e35 
TT36420
@ljsalvatierra-factorlibre @eugenios73
[MIG] account_invoice_margin_sale: Migration to 16.0
edcacf8
@eugenios73
[UPD] Update account_invoice_margin_sale.pot
015a4cc
@sanrav @eugenios73
Added translation using Weblate (French (France) (fr_FR))
a37086e
@sanrav @eugenios73
Translated using Weblate (French (France) (fr_FR))
753c4bd 
Currently translated at 100.0% (3 of 3 strings)

Translation: margin-analysis-16.0/margin-analysis-16.0-account_invoice_margin_sale
Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-16-0/margin-analysis-16-0-account_invoice_margin_sale/fr_FR/
@Gelo-fl @eugenios73
Translated using Weblate (Spanish)
882114a 
Currently translated at 100.0% (3 of 3 strings)

Translation: margin-analysis-16.0/margin-analysis-16.0-account_invoice_margin_sale
Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-16-0/margin-analysis-16-0-account_invoice_margin_sale/es/
@josep-tecnativa @eugenios73
[IMP] account_invoice_margin_sale: test performance improvement
383f98a 
- Include context keys for avoiding mail operations overhead.
@dreispt @eugenios73
[FIX] account_invoice_margin_sale: error creating invoice from sale o…
a321a78 
…rder

When sale_margin_security is also installed.
Closes OCA#194
@mymage @eugenios73
Added translation using Weblate (Italian)
385bf1c
@mymage @eugenios73
Translated using Weblate (Italian)
ae1be3e 
Currently translated at 100.0% (3 of 3 strings)

Translation: margin-analysis-16.0/margin-analysis-16.0-account_invoice_margin_sale
Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-16-0/margin-analysis-16-0-account_invoice_margin_sale/it/
@eugenios73
[IMP] account_invoice_margin_sale: pre-commit auto fixes
4b931bc
@eugenios73
[MIG] account_invoice_margin_sale: Migration to 17.0
f1b596c
@BhaveshHeliconia @eugenios73
[MIG] account_invoice_margin_sale: Migration to 18.0
892e948
@eugenios73
[UPD] Update account_invoice_margin_sale.pot
a5778f8
@OCA-git-bot @eugenios73
[BOT] post-merge updates
fdfde9e
Reyes4711-S73
Reyes4711-S73 approved these changes Mar 2, 2026
View reviewed changes

@Reyes4711-S73 Reyes4711-S73 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eugenios73 eugenios73 changed the title 19.0 mig account invoice margin sale superseed [19.0] [MIG] account_invoice_margin_sale superseed Mar 2, 2026
@eugenios73 eugenios73 force-pushed the 19.0-mig-account_invoice_margin_sale-superseed branch 2 times, most recently from 2ffec71 to 200c44c Compare March 2, 2026 15:47
@eugenios73

eugenios73 commented Mar 2, 2026

Copy link
Copy Markdown
Author

@dreispt I create this superseded from inactivity of the superseded PR, appling the modifications of your comment. Pleas can you review this PR? Thanks

@eugenios73 eugenios73 mentioned this pull request Mar 2, 2026
Closed
@gdgellatly

gdgellatly commented Mar 3, 2026

Copy link
Copy Markdown

Adding yourself as a contributor is not reasonable here IMO.

@eugenios73 eugenios73 force-pushed the 19.0-mig-account_invoice_margin_sale-superseed branch from 200c44c to 7089e0a Compare March 4, 2026 07:14
@eugenios73

eugenios73 commented Jun 4, 2026

Copy link
Copy Markdown
Author

@BhaveshHeliconia thanks for your review. Problems solved.

BhaveshHeliconia
BhaveshHeliconia approved these changes Jun 4, 2026
View reviewed changes

@BhaveshHeliconia BhaveshHeliconia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review LGTM!

@eugenios73 eugenios73 force-pushed the 19.0-mig-account_invoice_margin_sale-superseed branch from 639ae95 to c383879 Compare June 15, 2026 10:27
@Alexis-SDK

Alexis-SDK commented Jun 18, 2026

Copy link
Copy Markdown

account_invoice_margin has been merged. Is there anything still blocking this PR?

@eugenios73 eugenios73 force-pushed the 19.0-mig-account_invoice_margin_sale-superseed branch from c383879 to 78ac48b Compare June 19, 2026 11:38
@eugenios73

eugenios73 commented Jun 19, 2026

Copy link
Copy Markdown
Author

@Alexis-SDK I've been updated the code, now anything is blocking this PR. Thank for your review!

@OCA-git-bot

OCA-git-bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@Reyes4711-S73

Reyes4711-S73 commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

@OCA/accounting-maintainers Please, can you review/merge this PR?

tafaRU
tafaRU requested changes Jun 23, 2026
View reviewed changes
Comment thread account_invoice_margin_sale/models/account_invoice.py
cormaza added a commit to cormaza/margin-analysis that referenced this pull request Jun 24, 2026
@cormaza
Merge PR OCA#258 from refs/pull/258/head
7278c5d
@tafaRU

tafaRU commented Jun 25, 2026

Copy link
Copy Markdown
Member

@eugenios73 did you see #258 (review) ?

@eugenios73 eugenios73 force-pushed the 19.0-mig-account_invoice_margin_sale-superseed branch from 78ac48b to ef9ce0d Compare June 26, 2026 07:11
@eugenios73 eugenios73 force-pushed the 19.0-mig-account_invoice_margin_sale-superseed branch from ef9ce0d to f43ba98 Compare June 26, 2026 08:32
@eugenios73

eugenios73 commented Jun 26, 2026

Copy link
Copy Markdown
Author

@sergio-teruel can you review and merge this PR, please? Thanks in advance

@OCA-git-bot

OCA-git-bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@tafaRU

tafaRU commented Jun 26, 2026

Copy link
Copy Markdown
Member

/ocabot merge nobump

@OCA-git-bot

OCA-git-bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 19.0-ocabot-merge-pr-258-by-tafaRU-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 8efc647 into OCA:19.0 Jun 26, 2026
7 checks passed
@OCA-git-bot

OCA-git-bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 706c51a. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tafaRU tafaRU tafaRU approved these changes
+5 more reviewers
@dannyadair dannyadair dannyadair approved these changes
@Yusuke1998 Yusuke1998 Yusuke1998 approved these changes
@stferraro stferraro stferraro approved these changes
@Reyes4711-S73 Reyes4711-S73 Reyes4711-S73 approved these changes
@BhaveshHeliconia BhaveshHeliconia BhaveshHeliconia approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 mod:account_invoice_margin_sale Module account_invoice_margin_sale ready to merge series:19.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.