[19.0][ADD] l10n_jp_name_kana: kana reading for contacts, with a reusable mixin - #137
Open
AungKoKoLin1997 wants to merge 1 commit into
Open
[19.0][ADD] l10n_jp_name_kana: kana reading for contacts, with a reusable mixin#137AungKoKoLin1997 wants to merge 1 commit into
AungKoKoLin1997 wants to merge 1 commit into
Conversation
…ixin A name written in kanji has no usable collation order, and staff look records up by pronunciation, so the reading is both the sort key and the lookup key for such a name. That only holds if one pronunciation always yields one stored string, and it does not by itself: the same reading is typed in hiragana, in full-width katakana or in half-width katakana, and its parts are separated by an IME's U+3000 or by an import's U+0020. Readings are therefore normalized on write into a format the administrator chooses -- globally, or per model for the case where personal furigana is kept in hiragana while everything else stays in katakana -- and a search term is put through the same normalization before it is compared. A record is then found whichever kana form the term is typed in, from the contact lookup and from the search view alike. The behaviour lives in an abstract model so that a model gaining a reading needs no code of its own for it. Assisted-by: Claude Opus 5
This was referenced Aug 6, 2026
AungKoKoLin1997
marked this pull request as ready for review
August 6, 2026 05:31
AungKoKoLin1997
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a phonetic reading (カナ / ふりがな) to contacts, and the abstract model
that carries the same behaviour to other models.
@qrtl QT7089