[18.0][IMP] l10n_jp_summary_invoice: prevent deletion of a printed billing - #136
Open
nobuQuartile wants to merge 1 commit into
Open
[18.0][IMP] l10n_jp_summary_invoice: prevent deletion of a printed billing#136nobuQuartile wants to merge 1 commit into
nobuQuartile wants to merge 1 commit into
Conversation
OCA-git-bot
added
mod:l10n_jp_summary_invoice
nobuQuartile
marked this pull request as draft
July 7, 2026 07:46
nobuQuartile
marked this pull request as ready for review
July 7, 2026 09:20
smorita7749
reviewed
Jul 8, 2026
smorita7749
reviewed
Jul 8, 2026
nobuQuartile
force-pushed
the
18.0-imp-l10n_jp_summary_invoice-6980
branch
from
July 8, 2026 02:16
59671d4 to
b736e71
Compare
smorita7749
approved these changes
Jul 10, 2026
smorita7749
left a comment
smorita7749
left a comment
Contributor
There was a problem hiding this comment.
Code and functional review : LGTM
AungKoKoLin1997
left a comment
AungKoKoLin1997
left a comment
Contributor
There was a problem hiding this comment.
Instead of improving this module, I think we should work on account_billing_portal since we have a feature to send a email with pdf to the customer. We should also add a new config to enable this feature.
https://github.com/OCA/account-invoicing/pull/2186/changes#diff-caa53d83efd61773779aa32fd789f8881ed1eb50dc9a6e70bea654c453dc0ebbR36-R99
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QT6980