[19.0][MIG] l10n_jp_summary_invoice: Migration to 19.0 - #124
Open
AungKoKoLin1997 wants to merge 40 commits into
Open
[19.0][MIG] l10n_jp_summary_invoice: Migration to 19.0#124AungKoKoLin1997 wants to merge 40 commits into
AungKoKoLin1997 wants to merge 40 commits into
Conversation
OCA-git-bot
added
mod:l10n_jp_summary_invoice
AungKoKoLin1997
force-pushed
the
19.0-mig-l10n_jp_summary_invoice
branch
from
May 13, 2026 08:27
8892496 to
f482307
Compare
AungKoKoLin1997
marked this pull request as ready for review
May 13, 2026 08:29
Member
|
/ocabot migration l10n_jp_summary_invoice |
AungKoKoLin1997
marked this pull request as draft
May 19, 2026 01:16
AungKoKoLin1997
force-pushed
the
19.0-mig-l10n_jp_summary_invoice
branch
from
May 21, 2026 09:26
19047a8 to
cc6383b
Compare
AungKoKoLin1997
marked this pull request as ready for review
May 21, 2026 09:26
Contributor
|
The test error is from account_billing, which is not merged. |
Contributor
|
Functional review LGTM |
AungKoKoLin1997
force-pushed
the
19.0-mig-l10n_jp_summary_invoice
branch
from
May 28, 2026 07:24
cc6383b to
583d4b0
Compare
AungKoKoLin1997
force-pushed
the
19.0-mig-l10n_jp_summary_invoice
branch
from
June 4, 2026 06:40
ab5a7fb to
ee99d66
Compare
- Moved the option for selecting the alternative layout to the paper format settings - Added an option to include the partner’s address in the header when using the alternative layout - Added an option to display the document name on the report - Added an option to display the report date on the report - Added an option to display the report date label on the report - Refactored some code - Updated translations
Previously, credit notes were incorrectly treated as positive amounts in reporting and tax computation, just like regular invoices. This commit addresses the issue by introducing the `signed_quantity` field on `account.move.line` and refactoring the `_compute_tax_totals()` method to delegate tax computation to Odoo’s standard logic in `account.move`. Minor improvements were also made to the generated tax adjustment entries, including setting the correct due date and enhancing the reference field.
- Add amount_untaxed, amount_tax, amount_total computed fields - Change tax_totals from Binary to Json field (stored) - Display tax totals in form view using account-tax-totals-field widget - Add amount fields to list views with sum aggregation - Add "Print Summary Invoice" button to form header - Add currency_id filter and group-by option in search view - Style report table header with light gray background
…stment account lookup When the billing partner is a child contact, account_move_line stores the commercial partner as partner_id. Using partner_id.id directly in _get_inv_line_account_id caused _get_most_frequent_account_for_partner to return False, resulting in account_id=NULL and a DB constraint violation.
….move Add stored Many2one billing_id field to account.move to enable efficient searching and grouping by billing. Includes search filters, group by option, and view updates. Only non-cancelled billings are considered.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: l10n-japan-18.0/l10n-japan-18.0-l10n_jp_summary_invoice Translate-URL: https://translation.odoo-community.org/projects/l10n-japan-18-0/l10n-japan-18-0-l10n_jp_summary_invoice/
Add conditional rendering and text widget for the description field to handle empty names and preserve line breaks properly.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: l10n-japan-18.0/l10n-japan-18.0-l10n_jp_summary_invoice Translate-URL: https://translation.odoo-community.org/projects/l10n-japan-18-0/l10n-japan-18-0-l10n_jp_summary_invoice/
…d billing currency are different When company currency differs from billing currency, comparing tax amounts in company currency (via 'balance' and 'tax_amount' fields) causes floating-point precision errors that create unnecessary tax adjustments. Changes: - Use 'amount_currency' instead of 'balance' when summing invoice taxes - Use 'tax_amount_currency' instead of 'tax_amount' from billing totals - Add currency.is_zero() check to handle remaining FP precision issues - Ensure tax adjustment entry uses billing currency This ensures both values are compared in the billing currency before any company currency conversion, eliminating FP rounding accumulation errors. Example: With JPY company and USD invoices ($100.10 each): - Before fix: Compares ¥4,654.8 vs ¥4,654.7 (FP error) → false adjustment - After fix: Compares $30.03 vs $30.03 → no adjustment
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: l10n-japan-18.0/l10n-japan-18.0-l10n_jp_summary_invoice Translate-URL: https://translation.odoo-community.org/projects/l10n-japan-18-0/l10n-japan-18-0-l10n_jp_summary_invoice/
The labels held by `tax_totals` (e.g. "Untaxed Amount", tax group names) are translated when the value is built, so storing them freezes them in the language of the user who triggered the compute, and the report cannot translate them anymore. Stop storing the field, as in `account.move`, so that it is built in the language of the reader (i.e. the partner's one in the report). The amount fields need to stay stored, hence they are moved to their own compute method: sharing it with a non-stored field would update them on each read.
AungKoKoLin1997
force-pushed
the
19.0-mig-l10n_jp_summary_invoice
branch
from
July 29, 2026 09:29
ee99d66 to
347bb24
Compare
nobuQuartile
approved these changes
Jul 30, 2026
nobuQuartile
left a comment
nobuQuartile
left a comment
Contributor
There was a problem hiding this comment.
Code review and Fucntional review: LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #125
Includes: #109
@qrtl QT6740