Skip to content

[19.0][MIG] account_move_delivery_invoice: Migration to 19.0 - #114

Open
SanamiK wants to merge 9 commits into
OCA:19.0from
qrtl:19.0-add-account_move_delivery_invoice
Open

[19.0][MIG] account_move_delivery_invoice: Migration to 19.0#114
SanamiK wants to merge 9 commits into
OCA:19.0from
qrtl:19.0-add-account_move_delivery_invoice

Conversation

@SanamiK

@SanamiK SanamiK commented Apr 1, 2026

Copy link
Copy Markdown

@qrtl QT5088

@SanamiK SanamiK changed the title [5667][19.0][ADD] account_move_delivery_invoice [19.0][MIG] account_move_delivery_invoice: Migration to 19.0 Apr 1, 2026
@SanamiK
SanamiK force-pushed the 19.0-add-account_move_delivery_invoice branch 2 times, most recently from adc58a8 to 98b19a0 Compare April 1, 2026 07:35
@AungKoKoLin1997

Copy link
Copy Markdown
Contributor

@SanamiK Squash the last two commits since they are same.

I am wondering why the github workflows are waiting approval.
@yostashiro That is something you could approve?

@yostashiro

Copy link
Copy Markdown
Member

I am wondering why the github workflows are waiting approval. @yostashiro That is something you could approve?

Yes, approved. ;)

@SanamiK
SanamiK force-pushed the 19.0-add-account_move_delivery_invoice branch from 98b19a0 to c1e43c3 Compare April 2, 2026 06:21
@SanamiK

SanamiK commented Apr 2, 2026

Copy link
Copy Markdown
Author

@AungKoKoLin1997

Squash the last two commits since they are same

Done! Thank you for your suggestion.

<field name="inherit_id" ref="account.view_move_form" />
<field name="arch" type="xml">
<xpath expr="//field[@name='narration']" position="after">
<field name="show_delivery_note_narration" invisible="1" />

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this removed?

@SanamiK SanamiK Apr 2, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refer to the WARNING by odoo-module-migrator:

Fields that are required by Python expressions (invisible, column_invisible,
readonly, required, context, domain) are now added automatically as invisible
and readonly. You can remove these fields from XML views unless they are
necessary for specific logic. More details: odoo/odoo#137031

It seems that Odoo 19.0 automatically adds the field if it is necessary.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Didn't know.

@AungKoKoLin1997 AungKoKoLin1997 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functional Review: LGTM

Image Image Image

@yostashiro yostashiro left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit experimental, but could we take this chance to add a commit to make readme fragments bilingual (Japanese first, then English)?

@SanamiK

SanamiK commented Apr 3, 2026

Copy link
Copy Markdown
Author

add Japanese description to README!

@SanamiK
SanamiK force-pushed the 19.0-add-account_move_delivery_invoice branch from 2aa0cad to 9ad3129 Compare April 3, 2026 09:20
@SanamiK
SanamiK force-pushed the 19.0-add-account_move_delivery_invoice branch from 9ad3129 to 6f4efe7 Compare May 1, 2026 08:30
@OCA-git-bot OCA-git-bot added mod:account_move_delivery_invoice Module account_move_delivery_invoice series:19.0 labels May 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mod:account_move_delivery_invoice Module account_move_delivery_invoice series:19.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants