Skip to content

[18.0][MIG] account_billing_from_cutoff: migration to 18.0 - #110

Merged
OCA-git-bot merged 5 commits into
OCA:18.0from
qrtl:18.0-mig-account_billing_from_cutoff
Aug 13, 2026
Merged

[18.0][MIG] account_billing_from_cutoff: migration to 18.0#110
OCA-git-bot merged 5 commits into
OCA:18.0from
qrtl:18.0-mig-account_billing_from_cutoff

Conversation

@AungKoKoLin1997

@AungKoKoLin1997 AungKoKoLin1997 commented Feb 23, 2026

Copy link
Copy Markdown
Contributor

@qrtl QT5606

@AungKoKoLin1997
AungKoKoLin1997 force-pushed the 18.0-mig-account_billing_from_cutoff branch from 264f0cd to 756099a Compare February 24, 2026 03:43
@AungKoKoLin1997
AungKoKoLin1997 marked this pull request as draft May 19, 2026 01:17
@AungKoKoLin1997
AungKoKoLin1997 force-pushed the 18.0-mig-account_billing_from_cutoff branch from 756099a to 7c232d6 Compare June 4, 2026 09:18
@OCA-git-bot OCA-git-bot added mod:l10n_jp_summary_invoice Module l10n_jp_summary_invoice series:18.0 mod:account_billing_from_cutoff Module account_billing_from_cutoff labels Jun 4, 2026
@AungKoKoLin1997
AungKoKoLin1997 force-pushed the 18.0-mig-account_billing_from_cutoff branch from 7c232d6 to b26e89b Compare June 4, 2026 09:22
@OCA-git-bot OCA-git-bot removed the mod:l10n_jp_summary_invoice Module l10n_jp_summary_invoice label Jun 4, 2026
@AungKoKoLin1997
AungKoKoLin1997 marked this pull request as ready for review June 4, 2026 09:22
@AungKoKoLin1997
AungKoKoLin1997 force-pushed the 18.0-mig-account_billing_from_cutoff branch from b26e89b to 4ea7445 Compare June 4, 2026 09:23
yostashiro
yostashiro requested changes Jun 10, 2026
View reviewed changes
Comment thread account_billing_from_cutoff/wizards/account_billing_cutoff.py
Comment thread account_billing_from_cutoff/wizards/account_billing_cutoff.py Outdated
Comment thread account_billing_from_cutoff/tests/test_account_billing_from_cutoff.py
@AungKoKoLin1997
AungKoKoLin1997 force-pushed the 18.0-mig-account_billing_from_cutoff branch from 4ea7445 to 9ce83f6 Compare June 11, 2026 07:34
@AungKoKoLin1997

AungKoKoLin1997 commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

Depends on OCA/account-invoicing#2318

nobuQuartile
nobuQuartile reviewed Jul 8, 2026
View reviewed changes
Comment thread account_billing_from_cutoff/wizards/account_billing_cutoff.py Outdated
@AungKoKoLin1997
AungKoKoLin1997 force-pushed the 18.0-mig-account_billing_from_cutoff branch from 9ce83f6 to 49ea11c Compare July 13, 2026 02:39
@AungKoKoLin1997
AungKoKoLin1997 force-pushed the 18.0-mig-account_billing_from_cutoff branch from 49ea11c to d533a86 Compare July 13, 2026 02:51
nobuQuartile
nobuQuartile approved these changes Aug 3, 2026
View reviewed changes

@nobuQuartile nobuQuartile left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: Code review and functional review.

Minor point.

Comment thread account_billing_from_cutoff/readme/CONTRIBUTORS.md
@AungKoKoLin1997
AungKoKoLin1997 force-pushed the 18.0-mig-account_billing_from_cutoff branch 2 times, most recently from 7ae1b1e to 82a48e8 Compare August 6, 2026 07:03
@AungKoKoLin1997
AungKoKoLin1997 force-pushed the 18.0-mig-account_billing_from_cutoff branch from 82a48e8 to 77b7691 Compare August 6, 2026 07:04
yostashiro
yostashiro reviewed Aug 12, 2026
View reviewed changes
Comment thread account_billing_from_cutoff/wizards/account_billing_cutoff.py
Comment thread account_billing_from_cutoff/wizards/account_billing_cutoff.py
@AungKoKoLin1997
AungKoKoLin1997 force-pushed the 18.0-mig-account_billing_from_cutoff branch from 77b7691 to 9f54ed1 Compare August 12, 2026 09:58
@AungKoKoLin1997

AungKoKoLin1997 commented Aug 12, 2026

Copy link
Copy Markdown
Contributor Author

I updated to set threshold date from cutoff and consider threshold_date_type when searching the existing billing.

@AungKoKoLin1997
AungKoKoLin1997 force-pushed the 18.0-mig-account_billing_from_cutoff branch from 9f54ed1 to 6ddeb41 Compare August 12, 2026 10:37
yostashiro
yostashiro reviewed Aug 12, 2026
View reviewed changes
Comment thread account_billing_from_cutoff/wizards/account_billing_cutoff.py
Comment on lines +83 to +90
xml_id = (
"account_billing.action_customer_billing"
if self.bill_type == "out_invoice"
else "account_billing.action_supplier_billing"
)
action = self.env["ir.actions.act_window"]._for_xml_id(xml_id)
action["domain"] = [("id", "in", billings.ids)]
return action

@yostashiro yostashiro Aug 12, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be part of the migration commit?

@AungKoKoLin1997 AungKoKoLin1997 Aug 13, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It is since we have to adjust view type in migration commit.
Updated!.

@AungKoKoLin1997
[MIG] account_billing_from_cutoff: migration to 18.0
14353a9
@AungKoKoLin1997
[FIX] account_billing_from_cutoff: set threshold date from cutoff and…
90ba8bf 
… match billing by bank

- Group moves by remit-to bank and restrict the existing-billing lookup to the
  current company, so invoices with different partner banks are not merged.
- Set threshold_date from the wizard's cutoff date on new billings, and raise it
  on an updated billing, so validation is not blocked by lines dated after it.
- Only reuse a billing that is based on invoice dates, as the cutoff date is
  derived from the invoice date.

The threshold date handling is documented in the usage section.
@AungKoKoLin1997
[IMP] account_billing_from_cutoff: sort billing lines and require bil…
ac94731 
…l_type

Keep the line order of an updated billing consistent with manually created
billings, and make bill_type required as it is always set from the action
context.
@AungKoKoLin1997
AungKoKoLin1997 force-pushed the 18.0-mig-account_billing_from_cutoff branch from 6ddeb41 to ac94731 Compare August 13, 2026 02:51
yostashiro
yostashiro approved these changes Aug 13, 2026
View reviewed changes

@yostashiro yostashiro left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review.

@yostashiro

yostashiro commented Aug 13, 2026

Copy link
Copy Markdown
Member

/ocabot merge nobump
/ocabot migration account_billing_from_cutoff

@OCA-git-bot

OCA-git-bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot

OCA-git-bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-110-by-yostashiro-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Aug 13, 2026
@OCA-git-bot OCA-git-bot mentioned this pull request Aug 13, 2026
Open
10 tasks
@OCA-git-bot
OCA-git-bot merged commit 8f6e718 into OCA:18.0 Aug 13, 2026
7 checks passed
@OCA-git-bot

OCA-git-bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at db6ff9a. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yostashiro yostashiro yostashiro approved these changes
+1 more reviewer
@nobuQuartile nobuQuartile nobuQuartile approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 mod:account_billing_from_cutoff Module account_billing_from_cutoff ready to merge series:18.0

Projects

None yet

Milestone

18.0

Development

Successfully merging this pull request may close these issues.

4 participants

@AungKoKoLin1997 @yostashiro @OCA-git-bot @nobuQuartile