[IMP] github_connector: Add input validation for Github Name in sync wizard#143
Open
BhaveshHeliconia wants to merge 1 commit into
Open
[IMP] github_connector: Add input validation for Github Name in sync wizard#143BhaveshHeliconia wants to merge 1 commit into
BhaveshHeliconia wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior:
When navigating to the associated "Mod. Versions" list from the smart buttons on the odoo.lib.python, odoo.lib.bin, or odoo.author form views, the list view is filtered using the search_default_<field_name> context passing the raw database ID. Because the target field is a Many2many/Many2one relationship, the Odoo web client often fails to resolve the display name in time, resulting in the search facet displaying an ugly, raw database integer (e.g., Python Lib Dependencies: 9) to the end-user.
Benefits:
The view is now filtered silently and cleanly via the domain.
Completely hides the raw database ID from the search bar UI, providing a much more professional and seamless User Experience.
Applies this UX fix simultaneously to Authors, Python Libs, and Bin Libs due to the mixin inheritance.