[FIX] agreement_legal: use dedicated root menu on uninstall#116
Merged
Conversation
Contributor
|
Hi @ygol, |
tarteo
suggested changes
Jul 1, 2026
tarteo
left a comment
tarteo
left a comment
Member
There was a problem hiding this comment.
Tested, but it seems the menu is still gone following the steps in the issue
Member
Author
|
@tarteo Menu item is there but inactive. I will see if we can reactivate it when |
max3903
force-pushed
the
18.0-fix-agreement_legal-106
branch
from
2a2be0b to
df3f97c
Compare
Fixes OCA#106 Use a dedicated legal app root menu instead of reusing agreement.agreement_menu, hide the base app menu while legal is installed, and restore it via uninstall_hook. Co-authored-by: Cursor <cursoragent@cursor.com>
max3903
force-pushed
the
18.0-fix-agreement_legal-106
branch
from
99f5d6c to
3580ac0
Compare
Member
Author
|
@tarteo Can you please update your review? |
tarteo
approved these changes
Jul 3, 2026
Member
|
Didn't have time to test it, but I trust you :) |
Member
Author
|
/ocabot merge minor |
Contributor
|
What a great day to merge this nice PR. Let's do it! |
Contributor
|
Congratulations, your PR was merged at 82bafc3. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #106
Changes
agreement_legal_menu_rootinstead of reusingagreement.agreement_menuagreement.agreement_menu_rootwhileagreement_legalis installedValidation
oca_run_testsinghcr.io/oca/oca-ci/py3.10-odoo18.0:latest, 52 tests, 0 failures)Made with Cursor