[18.0][ADD] account_move_from_epd: Materialize early payment discount - #2328
Open
grindtildeath wants to merge 4 commits into
Open
[18.0][ADD] account_move_from_epd: Materialize early payment discount#2328grindtildeath wants to merge 4 commits into
grindtildeath wants to merge 4 commits into
Conversation
OCA-git-bot
added
series:18.0
mod:account_move_from_epd
TDu
approved these changes
Jun 16, 2026
TDu
left a comment
TDu
left a comment
Member
There was a problem hiding this comment.
LG, minor comments and also there is an issue with the pre-commits.
Could add the reconciliation part in the unit test to improve the code coverage of _compute_generated_epd_move_not_reconciled but not a necessity.
florentx
approved these changes
Jun 24, 2026
| invoice_pay_term_lines.matched_debit_ids.debit_move_id | ||
| | invoice_pay_term_lines.matched_credit_ids.credit_move_id | ||
| ) | ||
| move.generated_epd_move_not_reconciled = not bool( |
There was a problem hiding this comment.
Suggested change
| move.generated_epd_move_not_reconciled = not bool( | |
| move.generated_epd_move_not_reconciled = not ( |
| epd_values[category].get(payment_term_line, {}).items() | ||
| ): | ||
| epd_line_vals_list.append( | ||
| {**dict(grouping_dict), **vals, "partner_id": partner.id} |
There was a problem hiding this comment.
Does it need the dict(...) if it is already a dict?
Suggested change
| {**dict(grouping_dict), **vals, "partner_id": partner.id} | |
| {**grouping_dict, **vals, "partner_id": partner.id} |
Contributor
|
This PR has the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This module allows to materialize an 'Early Payment Discount' from an
invoice into a journal entry on a 'Miscellaneous' journal.
As Early Payment Discount cannot be applied once an invoice is partially
reconciled, the wizard allows to generate a journal entry using the full
EPD amount.