Update to hannah-proto 3.2.0, add compat_version interceptor - #162
Merged
Conversation
Wires compat_interceptor.compatVersionInterceptor into the gRPC client alongside the existing protocolVersionInterceptor (additive, not a replacement) — a breaking change scoped to one message no longer disconnects this adapter, only calls that actually use the affected message. Also picks up the 2.1.0 -> 3.2.0 jump the adapter had missed: Satellite/GetSatellitesResponse/SetSatelliteDisplayNameRequest moved from the control to the satellite module in hannah-proto 3.0.0 - the adapter's tsc --noEmit was broken against any hannah-proto newer than 2.x until this. Verified: tsc --noEmit, eslint, full test suite (80 unit + 56 package tests) all green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wires
compat_interceptor.compatVersionInterceptorinto the gRPC client alongside the existingprotocolVersionInterceptor(additive, not a replacement) — a breaking change scoped to one message no longer disconnects this adapter, only calls that actually use the affected message.Also picks up the 2.1.0 → 3.2.0 jump the adapter had missed:
Satellite/GetSatellitesResponse/SetSatelliteDisplayNameRequestmoved from thecontrolto thesatellitemodule in hannah-proto 3.0.0 —tsc --noEmitwas broken against any hannah-proto newer than 2.x until this.Test plan
npm run check(tsc --noEmit, both tsconfigs) — cleannpm run lint— cleannpm test— 80 unit tests + 56 package tests, all passing