feat: expose file id in message output#12
Merged
Conversation
The files array in `message list`/`message get` only carried name, mimetype, permalink and size — not the id. Without the id there was no way to pull an attachment seen in a message through `file download` / `file info`, since both take a file id. Add it to CompactFile so the download path is actually reachable from a message. Also document the file info/download/upload commands in the usage guide, which weren't covered before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
filesarray onmessage list/message getwas missing the fileid— it only carried name, mimetype, permalink and size. That left thefile downloadandfile infocommands unreachable for attachments discovered through a message, since both take a file id and the only place the id appeared was buried in the permalink URL.This adds
idto the compact file metadata so the download path works end to end: read a message, grab the attachment id, pull the bytes withfile download.Also documents the
file info/file download/file uploadcommands in the usage guide — they existed but werent written up anywhere.Test
go build ./...,go vet ./...cleanfile download/info/uploadhelp and that message output now includes the id fieldNeed help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.