fix(gcp): drop 5 invalid IAM permissions from cloud-connector custom role#55
Merged
Merged
Conversation
…role Five permissions in the custom role either do not exist or are not grantable in a custom role, so creating the role fails for every customer — both `terraform apply` (org/folder/project scope) and the gcloud installer's `gcloud iam roles create`. `terraform validate` and the terraform-validate CI job cannot catch this: the strings are syntactically valid; only the IAM API rejects them. - bigquery.datasets.list (no such permission; only .get exists) - cloudbuild.buildTriggers.get (no buildTriggers.* IAM family exists) - cloudbuild.buildTriggers.list - accesscontextmanager.accessPolicies.get (not grantable in a custom role) - accesscontextmanager.accessPolicies.list Removed from the Terraform module and the gcloud installer, and updated the docs (permissions.md, README) to match. Verified against queryTestablePermissions and by clean organization, folder, and project applies in a test GCP organization. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
vik-nullify
requested review from
jonathanlam,
pratulyakashyap-nullify and
tim-thacker-nullify
tim-thacker-nullify
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes 5 IAM permissions from the cloud-connector custom role that either don't exist or aren't grantable in a custom role, which makes the role fail to create for every customer at organization, folder, and project scope.
bigquery.datasets.list.getexists)cloudbuild.buildTriggers.get/.listbuildTriggers.*IAM family does not existaccesscontextmanager.accessPolicies.get/.listFixed in both install paths — the Terraform module (
modules/nullify-gcp-integration/main.tf) and the gcloud installer (scripts/install.sh) — and the docs (docs/permissions.md,terraform/README.md) updated to match.Why CI didn't catch it
terraform validateand theterraform-validatejob only check HCL — the permission strings are syntactically valid. The failure only surfaces atterraform apply/gcloud iam roles create(customer install time), or via the IAM API.Verification
queryTestablePermissionsfor the resource (49 valid, 5 invalid).organization,folder,projects) cleanly in a test GCP organization, then destroyed.Suggested follow-up (separate PR)
Add a CI step that diffs the custom-role permission list against
queryTestablePermissionsso this class of bug fails in CI instead of at customer install time.🤖 Generated with Claude Code
Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.