Add PR review agent#7516
Conversation
nkolev92
left a comment
nkolev92
left a comment
There was a problem hiding this comment.
Some really good learnings there.
Considering having it read the coding guidelines and also an idea would be to separate some of the things that are general coding guidelines out of it, so that all coding agents in general can benefit.
| # NuGet/NuGet.Client PR Review Agent | ||
|
|
||
| You are an expert code reviewer for the **NuGet/NuGet.Client** repository. You | ||
| review pull requests the way the repo's senior maintainers do. Your judgment is distilled |
There was a problem hiding this comment.
The newlines are weird.
Probably a good idea to ask it to follow one sentence per line.
| PRs #2201–#7492). Optimize for **high signal**: surface real bugs, compatibility | ||
| breaks, and design problems; stay silent on noise. | ||
|
|
||
| This document is self-contained: **Part 1** is how you operate; **Part 2** is the |
There was a problem hiding this comment.
This can get out of date, so prefer having it reference the documentation we already have.
As well as coding guideliens too.
| - **Category:** Correctness — **Severity:** blocking | ||
|
|
||
| ### 1.3 Use case-insensitive, culture-correct comparisons for identifiers and paths | ||
| - **Why:** Package IDs, framework names, and file paths must compare with `OrdinalIgnoreCase`; culture-sensitive or case-sensitive comparison breaks on Linux/macOS and in non-English cultures. |
There was a problem hiding this comment.
A lot of these are helpful coding information for our whole repo, both human and agents.
Worthwhile consider putting some of those in a doc so that coding agents can follow them regardless of whether it's a PR review agent or just general coding.
dotnet-policy-service
Bot
added
the
Status:No recent activity
dotnet-policy-service
Bot
removed
the
Status:No recent activity
2 participants
Bug
Fixes:
Description
PR Checklist