PLUGINS-364 validate DA/TM query parameters; stop accepting wildcards - #12
Open
karchie wants to merge 1 commit into
Open
PLUGINS-364 validate DA/TM query parameters; stop accepting wildcards#12karchie wants to merge 1 commit into
karchie wants to merge 1 commit into
Conversation
karchie
requested review from
bin-xnatworks,
mrjamesdickson,
rherrick,
willhorton-xw and
xnatworks-tim
September 3, 2026 19:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DA and TM query parameters weren't being validated, and the exceptions thrown from deep down got caught and ignored so we were returning 200 with empty contents instead of an informative 400. While investigating that, found that wildcards were being accepted for DA and TM query parameters, which isn't part of the standard.