Xnat 8577 1 - #13
Merged
Merged
Conversation
kathrynalpert
approved these changes
Jul 29, 2026
kathrynalpert
left a comment
kathrynalpert
left a comment
Contributor
There was a problem hiding this comment.
Approved pending removal of unused method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the name of the alternate success handler.
Avoiding circular dependency
Spring starts creating SecurityConfig.
As part of that, it calls SecurityConfig.setXnatSecurityExtensions(...), which needs to construct OpenIdSecurityExtension.
That needs OpenIdConnectFilter, whose constructor runs right now, mid-construction of SecurityConfig.
Since no bean is qualified with ALTERNATE_SUCCESS_HANDLER, it falls back to XDAT.getContextService().getBean(OnXnatLogin.class).
But OnXnatLogin is a bean that SecurityConfig itself is supposed to produce — and SecurityConfig hasn't finished being built yet, so it hasn't reached the point of registering that bean. The lookup finds nothing and returns null.
It's a bootstrap-order circular dependency: SecurityConfig → OpenIdSecurityExtension → OpenIdConnectFilter → (needs) OnXnatLogin → (defined by) SecurityConfig. There's no ordering of bean creation that satisfies this as written, so it will fail deterministically every time no alternate handler is supplied.