Skip to content

Potential fix for code scanning alert no. 13: Inefficient regular expression #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
NovasPlace wants to merge 1 commit into from
Closed

Potential fix for code scanning alert no. 13: Inefficient regular expression #53

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/redactor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@
// Absolute filesystem paths (Windows + POSIX)
const QUOTED_WIN_PATH_PATTERN = /(["'])(?:[A-Za-z]:[\\/]|\\\\[^\\/:*?"'<>|\r\n]+[\\/][^\\/:*?"'<>|\r\n]+[\\/])[^"'<>|\r\n]+\1/g;
const WIN_PATH_PATTERN = /(?:[A-Za-z]:[\\/](?:[^\s\\/:*?"<>|]+(?: (?![A-Za-z]:)[^\s\\/:*?"<>|]+)*[\\/])*[^\s\\/:*?"<>|]+(?: (?![A-Za-z]:)[^\s\\/:*?"<>|]+)*|\\\\[^\s\\/:*?"<>|]+[\\/][^\s\\/:*?"<>|]+(?:[\\/][^\s\\/:*?"<>|]+)*)/g;
const QUOTED_POSIX_PATH_PATTERN = /(["'])\/(?:home|Users|root|var|opt|etc|tmp|usr|mnt|srv|data|www|private|Volumes|Library|Applications)(?:\/[^"'\r\n]+)+\1/g;
const QUOTED_POSIX_PATH_PATTERN = /(["'])\/(?:home|Users|root|var|opt|etc|tmp|usr|mnt|srv|data|www|private|Volumes|Library|Applications)(?:\/[^\/"'\r\n]+)+\1/g;

Check failure on line 109 in src/redactor.ts

View workflow job for this annotation

GitHub Actions / Test (PostgreSQL 14) 

Unnecessary escape character: \/

Check failure on line 109 in src/redactor.ts

View workflow job for this annotation

GitHub Actions / Test (PostgreSQL 16) 

Unnecessary escape character: \/
const POSIX_PATH_PATTERN = /\/(?:home|Users|root|var|opt|etc|tmp|usr|mnt|srv|data|www|private|Volumes|Library|Applications)(?:\/[^\s:*?"<>|]+(?: [^\s:*?"<>|]+)*)+/g;

// ── Redactor class ────────────────────────────────────────────────────
Expand Down
Loading