Persistent MXFP8 for experts layers in MoE - #1940
Draft
kailash109 wants to merge 8 commits into
Draft
Conversation
…ate moe architecture spec to define emitted tensors
Collaborator
|
qq: how does the reward track vs the bf16 baseline here? also curious about logprobs mismatch |
Author
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Building off of #1937 and #1898, introduce persistent MXFP8 quantization for expert layers in MoE
Reuses blockwise casting logic from #1898 to write E8M0 scale factors on 1x32 blocks & deferred load of FP8 weights so optimizer states initialized on FP32 master weights, and pack E8M0 scale factors into uint8 bytes for VLLM ModelOpt-MXFP8 offline quantization.
_iter_sync_tensorswhich callsiter_serialized_fp8_tensorsnow handles both FP8 (hopper-style) and MXFP8 (blackwell-style).Todo: I still observe perf degradations from mxfp8 vs the bf16 baseline, need to debug why
