[GLM5.2] Use official IndexShare support - #1917
Draft
yapdianang wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Ubuntu <23232359+yapdianang@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Train GLM-5.2 with its published shared attention layout without runtime patches.
What changed
The previous versions created a separate attention indexer on every layer. GLM-5.2 instead creates full indexers on selected layers and shares them with nearby layers. The new pair reads
index_topk_freqandindex_skip_topk_offsetfrom the official model configuration and builds that layout directly.Verification
A live
zai-org/GLM-5.2-FP8B300 training test is in progress. This PR stays draft until model load, backward calculation, optimizer update, checkpoint reload, and sampling after weight sync pass.