fix(gateway): read nested multiplex profiles config - #53633
Closed
yungchentang wants to merge 1 commit into
Closed
Conversation
Collaborator
Duplicate of #51372 (earliest open canonical fix for #52562). Identical mechanism and file ( |
Contributor
Author
|
Confirmed duplicate after maintainer triage. #51372 is the earlier canonical PR for the nested gateway multiplex_profiles config path and is already approved, so I am closing this PR to avoid duplicate review work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gateway.multiplex_profilesfromconfig.yamlinto the runtimeGatewayConfigload path.multiplex_profilesoverrides the nested gateway value.Root Cause
load_gateway_config()normalizesconfig.yamlintogw_databefore callingGatewayConfig.from_dict(). The dataclass parser already knows how to readgateway.multiplex_profiles, but the loader never forwarded the nestedgatewayvalue, so configs written byhermes config set gateway.multiplex_profiles truewere effectively ignored.Fixes #52562
Tests
python -m pytest tests/gateway/test_config.py -qpython -m py_compile gateway/config.py tests/gateway/test_config.pygit diff --check