Skip to content

fix(gateway): read nested multiplex profiles config - #53633

Closed
yungchentang wants to merge 1 commit into
NousResearch:mainfrom
yungchentang:fix/gateway-multiplex-profiles-52562
Closed

fix(gateway): read nested multiplex profiles config#53633
yungchentang wants to merge 1 commit into
NousResearch:mainfrom
yungchentang:fix/gateway-multiplex-profiles-52562

Conversation

@yungchentang

Copy link
Copy Markdown
Contributor

Summary

  • Bridge gateway.multiplex_profiles from config.yaml into the runtime GatewayConfig load path.
  • Preserve the existing precedence where top-level multiplex_profiles overrides the nested gateway value.
  • Add a focused regression test for the CLI-written nested config shape.

Root Cause

load_gateway_config() normalizes config.yaml into gw_data before calling GatewayConfig.from_dict(). The dataclass parser already knows how to read gateway.multiplex_profiles, but the loader never forwarded the nested gateway value, so configs written by hermes config set gateway.multiplex_profiles true were effectively ignored.

Fixes #52562

Tests

  • python -m pytest tests/gateway/test_config.py -q
  • python -m py_compile gateway/config.py tests/gateway/test_config.py
  • git diff --check

@alt-glitch alt-glitch added type/bug Something isn't working comp/gateway Gateway runner, session dispatch, delivery area/config Config system, migrations, profiles P2 Medium — degraded but workaround exists sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades duplicate This issue or pull request already exists labels Jun 27, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

This was generated by AI during triage.

Duplicate of #51372 (earliest open canonical fix for #52562). Identical mechanism and file (gateway/config.py nested-section fallback for gateway.multiplex_profiles, mirroring max_concurrent_sessions). Prior identical twins #52596 and #52684 were already closed as duplicates of #51372. Note #51372 is a subset of the broader open #50094, which also fixes Bug-B (secret-scope isolation).

@yungchentang

Copy link
Copy Markdown
Contributor Author

Confirmed duplicate after maintainer triage. #51372 is the earlier canonical PR for the nested gateway multiplex_profiles config path and is already approved, so I am closing this PR to avoid duplicate review work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/config Config system, migrations, profiles comp/gateway Gateway runner, session dispatch, delivery duplicate This issue or pull request already exists P2 Medium — degraded but workaround exists sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gateway.multiplex_profiles config key not read by load_gateway_config

2 participants