fix(desktop): avoid false 'needs setup' on transient runtime-check timeouts - #51434
fix(desktop): avoid false 'needs setup' on transient runtime-check timeouts#51434infinitycrew39 wants to merge 2 commits into
Conversation
Duplicate of #37634 — same fix for the same mechanism: |
|
Merged via PR #51884 — your Thanks for the clean, well-targeted fix! Your approach of gating on Also credited in the PR body: @mohamedorigami-jpg (PR #37634) who independently proposed the notification-on-preserve idea. |
Summary
Desktop onboarding could incorrectly downgrade a previously-configured install to "needs setup" when runtime readiness probes returned only fallback errors (for example transient
request timed out: setup.runtime_check/ reconnect windows).This showed up as random status flapping (connected -> needs setup -> offline) and could block composer usage even though credentials were already valid.
Root Cause
refreshOnboarding()treated non-ready fallback results as authoritative and immediately setconfigured=false.Fallback results are intentionally non-authoritative (transport timeout/disconnect), so using them to downgrade state causes false negatives.
Fix
configured=truewhen readiness result is fallback-only and onboarding was not explicitly requested/manual.Tests
Added regression coverage:
Commits