Harden imported markup sanitization - #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
frame-src 'self' blob:toframe-src 'none'.Why
CodeQL reported three high-severity findings on
main:js/xss-through-domat the raw imported-markup parse boundary.js/double-escapinginstripMarkup.js/bad-tag-filterinstripMarkup.The existing detached parser and strict Reader allowlist already prevented execution in the hostile browser journey, but the raw parse remained a fragile custom security boundary. The new first pass uses an independently maintained sanitizer without weakening Reader's product-specific policy. The text helper now decodes entities exactly once and no longer treats a script-specific regular expression as a sanitizer.
User and developer impact
Authorized HTML, Markdown, and EPUB reading remains offline and preserves headings, document titles, safe internal or external handoff metadata, and byte-verified embedded raster images. Hostile active markup, foreign namespaces, event attributes, remote resources, popup affordances, and clobbering IDs remain blocked. DOMPurify is shipped locally, so the app introduces no runtime network dependency.
Validation
No tag, GitHub Release, supported binary, signing claim, or public artifact is introduced.