update cloud - #22
Merged
Merged
Conversation
- Add `pipeOverrideEstimateHeader()` to override estimate column headers while preserving theme-specific suffixes (e.g., from JAMA theme). - Refactor `pipeCiMergeReg()` to construct the merged CI header label dynamically from existing formatted columns instead of hardcoding it. - Replace inline header overrides in `tblRegLinearClass` and `tblUniRegLinearClass` with the new helper.
… CI abbreviation leak - Force `conf.int` to FALSE in `buildMultiRegTable()` and `buildUniRegTable()` when the journal theme is set to "qjecon". - This prevents gtsummary from generating unused `conf.low` and `conf.high` columns in the table body, avoiding stale "CI = Confidence Interval" footnotes when the columns are hidden by the theme.
- Update `buildSurvfitHeader()` in `survival.R` to construct the CI header dynamically using `gtsummary:::translate_string("CI")` instead of a hardcoded English string.
- Add `gtsummary::modify_abbreviation()` to the table pipeline in `tblsurvfit.b.R` to inject the translated "CI = Confidence Interval" source note globally into the table footer, ensuring the table matches `gtsummary`'s native localization behavior.
`gtsummary::style_number()` aggressively rounds numbers by default, which caused confidence levels with decimals (e.g., 95.5) to be incorrectly truncated or rounded to '96% CI' in the table headers. Bypassing `style_number()` and passing `confLevel` directly preserves the exact user-requested confidence level in survival tables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.