Repository navigation
Lower direct 1D surface atomic add instructions - #842
Closed
monsterlag wants to merge 3 commits into
Closed
monsterlag wants to merge 3 commits into
monsterlag wants to merge 3 commits into
Conversation
Preserve the old U32 image value, descriptor location and scalar register aliases for the supported native SUATOM form. Keep Strong(GPU) atomic coherence on the existing Device/Relaxed path and leave explicit MEMBAR instructions separate. Exercise authored instructions through production lowering, Maxwell CFG translation and SPIR-V emission, including strict mode rejection and high-register mapping. Assisted-by: OpenAI Codex Co-Authored-By: OpenAI Codex <noreply@openai.com>
Normally merge b2765ba, preserving all upstream allocator, depth, mesh, cache and workflow changes. Retain this topic's exact authored assertions. Assisted-by: OpenAI Codex Co-Authored-By: OpenAI Codex <noreply@openai.com>
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lower direct-descriptor native
0x593in its 1D U32 ADD/IGN/Strong(GPU) form to the existing Maxwell surface atomic. Preserve the returned old value, descriptor bank/offset, predication and scalar aliases. Unsupported forms, descriptor bounds and bank conflicts still fail.Strong(GPU) reuses the existing Device-scoped relaxed atomic; explicit MEMBARs remain independent. Encoding and memory-order references are documented with the fixture.
Updated on main
b2765ba6through a normal merge, preserving its allocator, depth, mesh and cache changes. Atf92f2c41, Linux source checks, Windows source checks, SPIR-V checks, Windows renderer/builder and Linux AppImage all pass. Separately, all12 unchanged authored programs passed full REGMAP/Maxwell CFG translation, IR checks and Vulkan1.3 SPIR-V validation against the combined private 2.0.6 integration; the released lowerer refused the supported authored form.These checks do not establish GPU numerical results or a particular visible game fix. No game-derived programs or caches are included.