Repository navigation
Conversation
…cache_load The check NotRexed#1082 added (2838e89) lifts program_cache_load from gpu/vk/vk_shader.cpp and compiles it against its own stand-ins. That function has called PROF_EXACT() since f226108, which the fixture does not define, so the check stops at compile time on main: "'PROF_EXACT' was not declared in this scope". The fixture now defines it as a no-op beside its other stand-ins. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bronze-ff
force-pushed
the
fix/cache-cleanup-test-prof
branch
from
November 9, 2026 19:13
4afabcd to
a8c4ebd
Compare
Contributor
Author
|
Closing: 96fece9 fixed the same fixture on main, so this change is no longer needed (merging main into this branch defined PROF_EXACT twice). Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tests/test_program_cache_cleanup.py, added in #1082, liftsprogram_cache_loadfromgpu/vk/vk_shader.cppand compiles it against the stand-ins intests/program_cache_cleanup_test.cpp. That function has calledPROF_EXACT();since f226108 (#989), which the fixture does not define, so since #1082 was merged the check stops at compile time onmain:The fixture now defines
PROF_EXACT()as a no-op beside its other stand-ins (logf,disk_init). One line, test only.Tested on CachyOS (GCC 16.2.1, Clang 23.1.4, Python 3.14) at fe611e4: the check fails before the change and its 6 tests pass after it with
--cxx g++,--cxx clang++, and both with--sanitize. Not run with MSVC here.Not covered:
tests/test_output_resolution.pyalso fails onmain; #1254 already fixes it.🤖 Generated with Claude Code