Repository navigation
fix(builder): explain unavailable selected game input - #1247
Merged
Merged
Conversation
Assisted-by: OpenAI Codex
Assisted-by: OpenAI Codex
hckrman101
approved these changes
Nov 9, 2026
hckrman101
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. The os.stat on the selected .nup is now wrapped and goes through fail(), so a missing or unavailable package gives the normal @@error with the path and the OS reason instead of the unexpected-exception handler. It's only the stat that's caught, so extraction and cache reuse are untouched, and genuine programming errors still reach the traceback path (the RuntimeError test covers that). tests/test_missing_nup.py is picked up automatically by run_all.py's tests/test_*.py discovery, it launches nothing and only touches temp dirs, and CI is all green including both Python source check jobs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A selected
.nupthat is missing or unavailable currently reaches the Builder's unexpected-exception handler. Report the failing path and OS reason through the normal error message, with guidance to reconnect the drive or choose the file again. Existing extraction and cache reuse behavior stays unchanged.Thanks to @biellbomfim for the report. Refs #1232.
Validation:
cli()/main()regression cases pass on Windows and WSL after merging upstream7dbdcdcintoccc6fb2.5375552; all nine hosted validation checks pass on the refreshed head, including the DLSS link check; release publishing is skipped for the PR.Only temporary authored files and stat-error doubles were used. No GUI, SDK/compiler, game, or real permission-denial scenario was exercised. This improves the missing/unavailable-input diagnostic; it does not establish why the reporter's path was unavailable or restore missing files.