Repository navigation
feat(vk): add centered 3D rotating Triforce loading screen with retro LOADING... overlay - #1068
Draft
oscarlosu-lab wants to merge 3 commits into
Draft
oscarlosu-lab wants to merge 3 commits into
oscarlosu-lab wants to merge 3 commits into
Conversation
oscarlosu-lab
added a commit
to oscarlosu-lab/Hookshot-TEST-commits
that referenced
this pull request
Nov 9, 2026
… LOADING... overlay
oscarlosu-lab
force-pushed
the
feat/loading-screen-triforce
branch
from
November 9, 2026 09:09
04ad965 to
09bab3f
Compare
Collaborator
|
Hi! This PR has merge conflicts with |
Contributor
Author
|
Hi @hckrman101! Done — merged the latest main into the branch and resolved all merge conflicts (including adapting to the new TLS objects, startup screen upload slots, and host table changes). Everything is clean and ready for review! |
Collaborator
|
Hi, I think this is probably better as a mod than in engine. |
hckrman101
marked this pull request as draft
November 9, 2026 19:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds an optional, centered 3D rotating golden Triforce animation with a retro
"LOADING..."indicator during zone and scene transitions, paying homage to classic 90s console loading screens while replacing the empty black screen and the tiny static corner icon.Replaces and supersedes #471 with a clean rebase on latest
main(2957106).Preview
Key Features & Design
d3ddepth draws, compute dispatches, and pass geometry).d3d == 0,f_disp == 0,f_draws <= 25, where the engine unloads the 3D scene).d3d >= 15), completely preventing false triggers during background streaming in towns or open areas.display_main()(vk_framegen.cpp) with a 16 ms timeout fallback so the 3D Triforce continues spinning smoothly at 60 FPS even when the CPU game thread stalls performing heavy I/O file loads.Loading animation: On/Offunder the in-game options menu (Options::loading_screen).Tested Scenarios