Fix buggy sidebar - #691
Merged
Merged
Conversation
hanlun0804
requested review from
martinenilsen1
and
a lite review from Copilot
August 12, 2026 10:33
Closed
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the shared Sidebar component implementation to improve behavior and maintainability, with a focus on clarifying component responsibilities and refining the collapsed-sidebar hover popover interactions.
Changes:
- Added JSDoc-style documentation to key sidebar components/hooks to clarify intended usage and behavior.
- Updated
SidebarMenuButtonhover behavior to keep the popover open briefly when moving the cursor from the button into the popover. - Minor styling tweaks (e.g., width/spacing utility adjustments) to align with the project’s Tailwind conventions.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Suppressed comments (1)
apps/web/src/components/shadcn/sidebar.tsx:570
{...props}is spread afteronClick/onMouseEnter/onMouseLeave, so any consumer-provided handlers for these props will override the sidebar’s internal hover open/close behavior (and the currentonClickwrapper is effectively bypassed ifprops.onClickexists). Consider spreadingpropsfirst and wrapping handlers so internal logic always runs while still delegating to user handlers.
cancelClose()
if (state === 'collapsed') setOpen(true)
}}
onMouseLeave={scheduleClose}
{...props}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.