feature/create-policy-for-pqc - #18
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds automatic reconciliation of Envoy Gateway ClientTrafficPolicy resources to enable PQC/hybrid TLS ECDH curve preference for operator-managed Gateway resources, including RBAC and Helm wiring.
Changes:
- Introduces a
ClientTrafficPolicymanager that creates/updates or deletes CTPs based on an env var toggle. - Ensures CTP reconciliation is invoked when Gateways are created/updated and attempts cleanup when Gateways are deleted.
- Adds RBAC permissions and Helm chart values/templates to support the new CRD and toggle.
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/controller/listener_manager.go | Deletes associated CTP when a Gateway is removed due to no remaining listeners. |
| internal/controller/httproute_controller.go | Attempts CTP cleanup when an old Gateway becomes unused. |
| internal/controller/gateway_manager.go | Calls ensureClientTrafficPolicy during Gateway create/update flows. |
| internal/controller/constants.go | Adds env var and naming constants for CTP support. |
| internal/controller/clienttrafficpolicy_manager.go | New reconciler logic for creating/updating/deleting ClientTrafficPolicy with PQC curves. |
| cmd/main.go | Registers Envoy Gateway API types into the controller scheme (currently gated by env var). |
| config/rbac/role.yaml | Adds ClusterRole rules for clienttrafficpolicies. |
| chart/gatewayapi-operator/values.yaml | Adds Helm values to enable/disable PQC via CTP. |
| chart/gatewayapi-operator/templates/rbac/role.yaml | Adds Helm RBAC rules for clienttrafficpolicies. |
| chart/gatewayapi-operator/templates/manager/manager.yaml | Adds Helm env var plumbing for the PQC toggle (currently has a rendering logic issue). |
| go.mod | Adds Envoy Gateway dependency and updates indirect deps. |
| go.sum | Updates module checksums accordingly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…nett/gatewayapi-operator into feature/create-policy-for-pqc
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
haahaakon
marked this pull request as ready for review
June 8, 2026 11:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.