Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The mimas configuration no longer actually enables KDE/Plasma despite the stated intent and remaining SDDM setup, which is likely an unintended functional regression.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Cleanup-focused PR intended to reduce NixOS/Home Manager closure size by removing unused Home Manager modules and simplifying evaluation.
Changes:
- Switch Home Manager entrypoint loading to
lib.modules.importApplyin the home configuration generator. - Remove custom Home Manager modules/config for AwesomeWM, Rofi, and WezTerm.
- Trim
mimasNixOS andnmelzer@mimasHome Manager config related to the removed desktop/window-manager setup.
File summaries
| File | Description |
|---|---|
| parts/home_configs.nix | Uses lib.modules.importApply for entrypoint import/application. |
| nixos/configurations/mimas.nix | Removes Plasma6/AwesomeWM enablement while leaving SDDM enabled. |
| home/modules/programs/wezterm/default.nix | Deletes the custom WezTerm Home Manager module/config. |
| home/modules/misc/rofi/default.nix | Deletes the custom Rofi wrapper/config module. |
| home/modules/misc/rofi/common.rasi | Removes shared Rofi theme/config file used by the deleted module. |
| home/modules/misc/awesome/default.nix | Deletes the custom AwesomeWM Home Manager module/config. |
| home/modules/default.nix | Stops exporting the removed modules. |
| home/configurations/nmelzer_at_mimas.nix | Removes AwesomeWM autostart and Flameshot enablement. |
Review details
- Files reviewed: 8/8 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
🔵 Needs a closer look
It removes major desktop/window-manager configuration pieces (including a large AwesomeWM module) and disables related system services, which could impact login/session availability on mimas and warrants manual verification.
Review details
- Files reviewed: 8/8 changed files
- Comments generated: 0 new
- Review effort level: Lite
Do some clean up to reduce system and home closures.