Skip to content

Support multiple engines and sessionmakers#13

Merged
Nnonexistent merged 3 commits into
mainfrom
12-support-multiple-engines-and-sessionmakers
Jun 19, 2026
Merged

Support multiple engines and sessionmakers#13
Nnonexistent merged 3 commits into
mainfrom
12-support-multiple-engines-and-sessionmakers

Conversation

@Nnonexistent

Copy link
Copy Markdown
Owner

No description provided.

@Nnonexistent Nnonexistent requested a review from Copilot June 19, 2026 02:16
@Nnonexistent Nnonexistent self-assigned this Jun 19, 2026
@Nnonexistent Nnonexistent linked an issue Jun 19, 2026 that may be closed by this pull request

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates pytest-sqlalchemy-alembic to support configuring multiple SQLAlchemy engine/sessionmaker setups via a new sqlalchemy_alembic_configs list, replacing the prior single-value ini options.

Changes:

  • Replaced single ini settings with a sqlalchemy_alembic_configs linelist and added parsing/validation for per-entry config objects.
  • Updated plugin setup fixtures to iterate over multiple configs and manage multiple test engines in one session.
  • Updated tests and documentation/examples to use the new configuration format.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 10 comments.

Show a summary per file
File Description
src/pytest_sqlalchemy_alembic/utils.py Adds a dataclass helper intended for runtime type-checking of config entries.
src/pytest_sqlalchemy_alembic/config.py Introduces sqlalchemy_alembic_configs parsing and PluginConfig.build_list() to produce multiple configs.
src/pytest_sqlalchemy_alembic/plugin.py Updates pytest integration/fixtures to setup multiple engines and optional DB management per config.
src/pytest_sqlalchemy_alembic/tests/test_plugin.py Adjusts tests to the new ini format and adds coverage for empty/under-configured entries.
README.md Documents the new sqlalchemy_alembic_configs format and updated fixture/config usage.
example_project/pytest.ini Adds example ini configuration using the new configs list.
example_project/pyproject.toml Removes old ini option usage from the example project.
example_project_async/pyproject.toml Updates async example to use the new configs list.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/pytest_sqlalchemy_alembic/config.py
Comment thread src/pytest_sqlalchemy_alembic/utils.py
Comment thread src/pytest_sqlalchemy_alembic/plugin.py
Comment thread src/pytest_sqlalchemy_alembic/plugin.py Outdated
Comment thread src/pytest_sqlalchemy_alembic/plugin.py Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread src/pytest_sqlalchemy_alembic/plugin.py Outdated
Comment thread src/pytest_sqlalchemy_alembic/plugin.py Outdated
Comment thread src/pytest_sqlalchemy_alembic/plugin.py Outdated
@Nnonexistent Nnonexistent merged commit d0d837f into main Jun 19, 2026
26 checks passed
@Nnonexistent Nnonexistent deleted the 12-support-multiple-engines-and-sessionmakers branch June 19, 2026 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support multiple engines and sessionmakers

2 participants