Support multiple engines and sessionmakers#13
Merged
Nnonexistent merged 3 commits intoJun 19, 2026
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates pytest-sqlalchemy-alembic to support configuring multiple SQLAlchemy engine/sessionmaker setups via a new sqlalchemy_alembic_configs list, replacing the prior single-value ini options.
Changes:
- Replaced single ini settings with a
sqlalchemy_alembic_configslinelist and added parsing/validation for per-entry config objects. - Updated plugin setup fixtures to iterate over multiple configs and manage multiple test engines in one session.
- Updated tests and documentation/examples to use the new configuration format.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| src/pytest_sqlalchemy_alembic/utils.py | Adds a dataclass helper intended for runtime type-checking of config entries. |
| src/pytest_sqlalchemy_alembic/config.py | Introduces sqlalchemy_alembic_configs parsing and PluginConfig.build_list() to produce multiple configs. |
| src/pytest_sqlalchemy_alembic/plugin.py | Updates pytest integration/fixtures to setup multiple engines and optional DB management per config. |
| src/pytest_sqlalchemy_alembic/tests/test_plugin.py | Adjusts tests to the new ini format and adds coverage for empty/under-configured entries. |
| README.md | Documents the new sqlalchemy_alembic_configs format and updated fixture/config usage. |
| example_project/pytest.ini | Adds example ini configuration using the new configs list. |
| example_project/pyproject.toml | Removes old ini option usage from the example project. |
| example_project_async/pyproject.toml | Updates async example to use the new configs list. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.