fix(security): 2 improvements across 2 files#1189
Open
tomaioo wants to merge 2 commits into
Open
Conversation
- Security: Hardcoded Absolute Paths Expose Internal Directory Structure - Security: Hardcoded Absolute Paths Expose Internal Directory Structure Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
- Security: Hardcoded Absolute Paths Expose Internal Directory Structure - Security: Hardcoded Absolute Paths Expose Internal Directory Structure Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix(security): 2 improvements across 2 files
Problem
Severity:
Medium| File:experiments/ets_intervals/src/evaluation.py:L19The evaluation scripts contain hardcoded absolute paths pointing to a specific user's home directory (
/home/ubuntu/statsforecast/...). This indicates that the code was committed without sanitizing local configurations. This breaks portability, leaks internal infrastructure details, and can cause unexpected runtime failures if the path is manipulated or expected to exist in deployment.Solution
Remove hardcoded absolute paths. Use relative paths, environment variables, or CLI arguments to determine the data directory dynamically.
Changes
experiments/ets_intervals/src/evaluation.py(modified)experiments/ces_intervals/src/evaluation.py(modified)