[FIX] Use specific exception types in date_features#833
Open
K2alyan wants to merge 1 commit into
Open
Conversation
Replace generic Exception raises with ValueError (invalid country code) and ImportError (missing holidays package), and add a test that verifies the ValueError path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
raise Exception(...)withraise ValueError(...)when a user passes an unsupported country code toCountryHolidaysraise Exception(...)withraise ImportError(...) from ewhen the optionalholidayspackage is not installed, preserving the original exception chaintest_country_holidays_invalid_countrythat verifies theValueErrorpathMotivation
Generic
Exceptionmakes it hard for callers to handle errors specifically.ValueErroris the right type for invalid input (a bad country code), andImportErroris the right type for a missing dependency. This also chains the originalModuleNotFoundErrorso the traceback retains the root cause.Test plan
pytest nixtla_tests/date_features/— all three tests should passtest_country_holidays_invalid_countryverifies theValueErroris raised when an invalid country code is provided