Skip to content

Bump transitive pytorch-lightning to 2.6.1 to remediate insecure checkpoint deserialization#821

Open
rogeliomj with Copilot wants to merge 3 commits into
mainfrom
copilot/ghsa-75m9-98v2-hjpm-fix-insecure-deserialization
Open

Bump transitive pytorch-lightning to 2.6.1 to remediate insecure checkpoint deserialization#821
rogeliomj with Copilot wants to merge 3 commits into
mainfrom
copilot/ghsa-75m9-98v2-hjpm-fix-insecure-deserialization

Conversation

Copilot AI commented Jun 1, 2026

Copy link
Copy Markdown

This PR addresses GHSA-75m9-98v2-hjpm / CVE-2026-31221, where pytorch-lightning<=2.6.0 can deserialize unsafe objects via LightningModule.load_from_checkpoint(). The lockfile now resolves to the lowest non-vulnerable version to remove the flagged path with minimal dependency churn.

  • Dependency remediation

    • Updated transitive pytorch-lightning resolution in uv.lock:
      • 2.5.52.6.1 (lowest non-vulnerable version available for this advisory).
    • No direct manifest dependency changes were required.
  • Reachability assessment

    • The vulnerable API is directly used in the repository:
      • experiments/salesforce-moirai/src/moirai_pipeline.py
      • experiments/foundation-time-series-arena/xiuhmolpilli/models/foundational/timesfm.py
    • Conclusion: the vulnerable code path is reachable when these experiment/model-loading paths ingest checkpoints.
    • Confidence: High (advisory names a specific API and direct call sites were confirmed).
  • Lockfile delta (illustrative)

    [[package]]
    name = "pytorch-lightning"
    -version = "2.5.5"
    +version = "2.6.1"
Original prompt

This section details the Dependabot vulnerability alert you should resolve

<alert_title>PyTorch Lightning load_from_checkpoint has an insecure checkpoint deserialization</alert_title>
<alert_description>PyTorch-Lightning versions 2.6.0 and earlier contain an insecure deserialization vulnerability (CWE-502) in the checkpoint loading mechanism. The LightningModule.load_from_checkpoint() method, which is commonly used to load saved model states, internally calls torch.load() without setting the security-restrictive weights_only=True parameter. This default behavior allows the deserialization of arbitrary Python objects via the Pickle module. A remote attacker can exploit this by providing a maliciously crafted checkpoint file, leading to arbitrary code execution on the victim's system when the file is loaded.</alert_description>

high
GHSA-75m9-98v2-hjpm, CVE-2026-31221
pytorch-lightning
pip
<vulnerable_versions>= 2.5.5</vulnerable_versions>
<patched_version></patched_version>
<manifest_path>uv.lock</manifest_path>

https://nvd.nist.gov/vuln/detail/CVE-2026-31221 https://github.com/Lightning-AI/pytorch-lightning https://www.notion.so/CVE-2026-31221-35d1e1393188815f8db7c4fd08076639 https://github.com/advisories/GHSA-75m9-98v2-hjpm

<task_instructions>Resolve this alert by updating the affected package to a non-vulnerable version. Prefer the lowest non-vulnerable version (see the patched_version field above) over the latest to minimize breaking changes. Include a Reachability Assessment section in the PR description. Review the alert_description field to understand which APIs, features, or configurations are affected, then search the codebase for usage of those specific items. If the vulnerable code path is reachable, explain how (which files, APIs, or call sites use the affected functionality) and note that the codebase is actively exposed to this vulnerability. If the vulnerable code path is not reachable, explain why (e.g. the affected API is never called, the vulnerable configuration is not used) and note that the update is primarily to satisfy vulnerability scanners rather than to address an active risk. If the advisory is too vague to determine reachability (e.g. 'improper input validation' with no specific API named), state that reachability could not be determined and explain why. Include a confidence level in the reachability assessment (e.g. high confidence if the advisory names a specific API and you confirmed it is or is not called, low confidence if the usage is indirect and hard to trace). If no patched version is available, check the alert_description field for a Workarounds section — the advisory may describe configuration changes or usage patterns that mitigate the vulnerability without a version update. If a workaround is available, apply it and leave a code comment referencing the advisory identifier explaining it is a temporary mitigation. If neither a patch nor a workaround is available, explain in the PR description why the alert cannot be resolved automatically so a human reviewer can take over. Inspect the repository to determine which package manager is used (e.g. lock files, config files, build scripts) and use that tooling to perform the update — do not edit lock files directly. If the version constraint in the manifest (e.g. package.json, Gemfile, pyproject.toml) caps the version below the fix, update the constraint first. For transitive dependencies, determine whether it is simpler to update the direct dependency that pulls in the vulnerable package or to update the transitive dependency directly, and choose the least disruptive approach. If upgrading to fix the vulnerability forces a major version bump or known breaking changes, review the changelog or release notes, then audit the codebase for usage of affected APIs and fix any breaking changes that are found. If the package manager fails to resolve dependencies (e.g. peer dependency conflicts, incompatible engine constraints), document the error in the PR description rather than attempting increasingly complex workarounds. After updating, check the lock file to confirm the package no longer resolves to a version in the vulnerable range. Keep changes minimal and tightly scoped. Ensure tests, build, type checking, and linting all pass after your changes. If there are any test, lint, or typechecking failures, investigate whether they are caused by the update and fix them if so — do not leave broken tests in the PR. If they were already present before the update, note them in the PR description so a human reviewer can assess whether they are related.</task_instructions>

@CLAassistant

CLAassistant commented Jun 1, 2026

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ rogeliomj
❌ Copilot
You have signed the CLA already but the status is still pending? Let us recheck it.

Copilot AI changed the title [WIP] Fix insecure checkpoint deserialization in PyTorch Lightning Bump transitive pytorch-lightning to 2.6.1 to remediate insecure checkpoint deserialization Jun 1, 2026
Copilot AI requested a review from rogeliomj June 1, 2026 19:13
@rogeliomj
rogeliomj marked this pull request as ready for review June 1, 2026 19:27
@github-actions

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor
Experiment Results

Experiment 1: air-passengers

Description:

variable experiment
h 12
season_length 12
freq MS
level None
n_windows 1

Results:

metric timegpt-1 timegpt-1-long-horizon SeasonalNaive Naive
mae 12.6793 11.0623 47.8333 76
mape 0.027 0.0232 0.0999 0.1425
mse 213.936 199.132 2571.33 10604.2
total_time 2.2926 2.4426 0.0047 0.0037

Plot:

Experiment 2: air-passengers

Description:

variable experiment
h 24
season_length 12
freq MS
level None
n_windows 1

Results:

metric timegpt-1 timegpt-1-long-horizon SeasonalNaive Naive
mae 58.1031 58.4587 71.25 115.25
mape 0.1257 0.1267 0.1552 0.2358
mse 4040.21 4110.79 5928.17 18859.2
total_time 1.5757 2.3244 0.004 0.0037

Plot:

Experiment 3: electricity-multiple-series

Description:

variable experiment
h 24
season_length 24
freq H
level None
n_windows 1

Results:

metric timegpt-1 timegpt-1-long-horizon SeasonalNaive Naive
mae 178.293 268.129 269.23 1331.02
mape 0.0234 0.0311 0.0304 0.1692
mse 121586 219467 213677 4.68961e+06
total_time 2.072 2.575 0.005 0.0045

Plot:

Experiment 4: electricity-multiple-series

Description:

variable experiment
h 168
season_length 24
freq H
level None
n_windows 1

Results:

metric timegpt-1 timegpt-1-long-horizon SeasonalNaive Naive
mae 465.532 346.976 398.956 1119.26
mape 0.062 0.0436 0.0512 0.1583
mse 835120 403762 656723 3.17316e+06
total_time 2.508 2.8997 0.0051 0.0047

Plot:

Experiment 5: electricity-multiple-series

Description:

variable experiment
h 336
season_length 24
freq H
level None
n_windows 1

Results:

metric timegpt-1 timegpt-1-long-horizon SeasonalNaive Naive
mae 558.684 459.764 602.926 1340.95
mape 0.0697 0.0565 0.0787 0.17
mse 1.2272e+06 739132 1.61572e+06 6.04619e+06
total_time 3.0842 2.0472 0.0053 0.0048

Plot:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants