i3blocks: handle multiple XDG_CONFIG_DIRS elements correctly#71339
Merged
Conversation
ofborg
Bot
added
10.rebuild-darwin: 0
worldofpeace
approved these changes
Oct 18, 2019
worldofpeace
left a comment
worldofpeace
left a comment
Contributor
There was a problem hiding this comment.
LGTM thanks @edef1c ✨
On NixOS, $XDG_CONFIG_DIRS always has multiple elements. Without this patch, it'll try to open() a rather nonsensical path full of colons.
Contributor
|
Thanks, this application matches the freedesktop spec now. I'm certain upstream should accept it, or at least I'd strongly advise they should. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
On NixOS, $XDG_CONFIG_DIRS always has multiple elements.
Without this patch, it'll try to open() a rather nonsensical path full of colons.
Upstream PR: vivien/i3blocks#405
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)